Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Side by Side Diff: chrome/browser/resources/settings/settings_dialog.html

Issue 1974193002: MD Settings: fix overflow scrolling for <settings-dialog> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bt-polish3
Patch Set: nit Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 1 <link rel="import" href="chrome://resources/cr_elements/icons.html">
2 <link rel="import" href="chrome://resources/html/polymer.html"> 2 <link rel="import" href="chrome://resources/html/polymer.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dialog-behavior/p aper-dialog-behavior.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dialog-behavior/p aper-dialog-behavior.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dialog-behavior/p aper-dialog-shared-styles.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dialog-behavior/p aper-dialog-shared-styles.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
6 6
7 <dom-module id="settings-dialog"> 7 <dom-module id="settings-dialog">
8 <template> 8 <template>
9 <style include="paper-dialog-shared-styles"></style> 9 <style include="paper-dialog-shared-styles"></style>
10 <style> 10 <style>
11 .body-content { 11 .body-container {
12 display: flex; 12 display: flex;
13 flex-direction: column; 13 flex-direction: column;
14 min-height: 120px; 14 min-height: 120px;
15 overflow-y: auto;
15 } 16 }
16 17
17 .dialog-content { 18 .dialog-content {
18 -webkit-padding-end: 0; 19 -webkit-padding-end: 0;
19 -webkit-padding-start: 0; 20 -webkit-padding-start: 0;
20 margin-bottom: 0; 21 margin-bottom: 0;
21 margin-top: 0; 22 margin-top: 0;
22 } 23 }
23 24
24 .footer-container { 25 .footer-container {
25 margin: 0; 26 margin: 0;
26 padding: 0; 27 padding: 0;
27 } 28 }
28 29
29 .top-row { 30 .title-container {
30 align-items: center; 31 align-items: center;
31 border-bottom: 1px solid rgba(0, 0, 0, 0.14); 32 border-bottom: 1px solid rgba(0, 0, 0, 0.14);
32 display: flex; 33 display: flex;
33 min-height: 52px; 34 min-height: 52px;
34 } 35 }
35 36
36 paper-icon-button { 37 paper-icon-button {
37 height: 20px; 38 height: 20px;
38 margin: 16px; 39 margin: 16px;
39 padding: 0; 40 padding: 0;
40 width: 20px; 41 width: 20px;
41 } 42 }
42 43
43 :host { 44 :host {
44 border-radius: 2px; 45 border-radius: 2px;
45 max-width: 800px; 46 max-width: 800px;
46 min-width: 512px; 47 min-width: 512px;
47 overflow: auto;
48 } 48 }
49 49
50 :host ::content .body, 50 :host ::content .body,
51 :host ::content .footer, 51 :host ::content .footer,
52 :host ::content paper-button { 52 :host ::content paper-button {
53 font-size: 92.86%; /* (13px / 14px) * 100 */ 53 font-size: 92.86%; /* (13px / 14px) * 100 */
54 } 54 }
55 55
56 :host ::content .body { 56 :host ::content .body {
57 margin: 12px 0 24px 0; 57 margin: 12px 0 24px 0;
58 } 58 }
59 59
60 :host ::content .button-container { 60 :host ::content .buttons {
61 -webkit-padding-end: 16px; 61 -webkit-padding-end: 16px;
62 -webkit-padding-start: 16px; 62 -webkit-padding-start: 16px;
63 display: flex; 63 display: flex;
64 justify-content: flex-end; 64 justify-content: flex-end;
65 margin-bottom: 12px; 65 margin-bottom: 12px;
66 } 66 }
67 67
68 :host ::content .button-container .cancel-button { 68 :host ::content .buttons .cancel-button {
69 -webkit-margin-end: 8px; 69 -webkit-margin-end: 8px;
70 color: var(--paper-grey-600); 70 color: var(--paper-grey-600);
71 } 71 }
72 72
73 :host ::content .footer { 73 :host ::content .footer {
74 background-color: var(--paper-grey-200); 74 background-color: var(--paper-grey-200);
75 margin: 0; 75 margin: 0;
76 padding: 20px; 76 padding: 20px;
77 } 77 }
78 78
(...skipping 12 matching lines...) Expand all
91 } 91 }
92 92
93 :host ::content .body, 93 :host ::content .body,
94 :host ::content .title { 94 :host ::content .title {
95 -webkit-padding-end: 24px; 95 -webkit-padding-end: 24px;
96 -webkit-padding-start: 24px; 96 -webkit-padding-start: 24px;
97 flex: 1; 97 flex: 1;
98 } 98 }
99 </style> 99 </style>
100 <div class="dialog-content"> 100 <div class="dialog-content">
101 <div class="top-row"> 101 <div class="title-container">
102 <content select=".title"></content> 102 <content select=".title"></content>
103 <paper-icon-button icon="cr:clear" on-tap="cancel" id="close"> 103 <paper-icon-button icon="cr:clear" on-tap="cancel" id="close">
104 </paper-icon-button> 104 </paper-icon-button>
105 </div> 105 </div>
106 <div class="body-content"> 106 <div class="body-container">
107 <content select=".body"></content> 107 <content select=".body"></content>
108 <content select=".button-container"></content> 108 </div>
109 <div class="button-container">
110 <content select=".buttons"></content>
109 </div> 111 </div>
110 </div> 112 </div>
111 <div class="footer-container"> 113 <div class="footer-container">
112 <content select=".footer"></content> 114 <content select=".footer"></content>
113 </div> 115 </div>
114 </template> 116 </template>
115 <script src="settings_dialog.js"></script> 117 <script src="settings_dialog.js"></script>
116 </dom-module> 118 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698