components/mus/public/cpp/lib/command_buffer_client_impl.cc - Issue 1974163003: Expose GpuMemoryBufferId through glGetImageivCHROMIUM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/public/cpp/lib/command_buffer_client_impl.cc

Issue 1974163003: Expose GpuMemoryBufferId through glGetImageivCHROMIUM. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/mus/gles2/command_buffer_local.cc ('K') | « components/mus/public/cpp/lib/command_buffer_client_impl.h ('k') | gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt » ('j') | gpu/command_buffer/cmd_buffer_functions.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/mus/public/cpp/lib/command_buffer_client_impl.cc

diff --git a/components/mus/public/cpp/lib/command_buffer_client_impl.cc b/components/mus/public/cpp/lib/command_buffer_client_impl.cc

index ebbee055ca086f572a6cf2934775d996fc7b292b..81e25cabc0e0427ed25496749feb8204272675dd 100644

--- a/components/mus/public/cpp/lib/command_buffer_client_impl.cc

+++ b/components/mus/public/cpp/lib/command_buffer_client_impl.cc

@@ -271,6 +271,11 @@ int32_t CommandBufferClientImpl::CreateGpuMemoryBufferImage(

return CreateImage(buffer->AsClientBuffer(), width, height, internalformat);

}

+int32_t CommandBufferClientImpl::GetImageGpuMemoryBufferId(unsigned image_id) {

+ NOTIMPLEMENTED();

piman 2016/05/26 21:16:07 ditto?

erikchen 2016/05/26 21:41:27 Done.

+ return -1;

void CommandBufferClientImpl::SignalQuery(uint32_t query,

const base::Closure& callback) {

// TODO(piman)