components/mus/gles2/command_buffer_local.cc - Issue 1974163003: Expose GpuMemoryBufferId through glGetImageivCHROMIUM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/gles2/command_buffer_local.cc

Issue 1974163003: Expose GpuMemoryBufferId through glGetImageivCHROMIUM. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/mus/gles2/command_buffer_local.h ('k') | components/mus/public/cpp/lib/command_buffer_client_impl.h » ('j') | components/mus/public/cpp/lib/command_buffer_client_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/mus/gles2/command_buffer_local.cc

diff --git a/components/mus/gles2/command_buffer_local.cc b/components/mus/gles2/command_buffer_local.cc

index 971ccec6eb7fb49c2589662779465d63e457b147..ebae57ef084223b6e807a1ab9a6d8d0188cf1099 100644

--- a/components/mus/gles2/command_buffer_local.cc

+++ b/components/mus/gles2/command_buffer_local.cc

@@ -309,6 +309,11 @@ int32_t CommandBufferLocal::CreateGpuMemoryBufferImage(size_t width,

return CreateImage(buffer->AsClientBuffer(), width, height, internal_format);

}

+int32_t CommandBufferLocal::GetImageGpuMemoryBufferId(unsigned image_id) {

+ NOTIMPLEMENTED();

piman 2016/05/26 21:16:07 Can you add a TODO?

erikchen 2016/05/26 21:41:27 Done.

+ return -1;

void CommandBufferLocal::SignalQuery(uint32_t query_id,

const base::Closure& callback) {

DCHECK(CalledOnValidThread());