Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 197403004: Exit the installer gracefully if the processor doesn't support SSE2. (Closed)

Created:
6 years, 9 months ago by grt (UTC plus 2)
Modified:
6 years, 9 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Exit the installer gracefully if the processor doesn't support SSE2. This change builds the files in chrome/installer/setup targeting older CPUs so that setup.exe can safely probe the CPU and exit early with a well-defined process exit code if the processor doens't support SSE2. BUG=350175 R=cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256668

Patch Set 1 #

Total comments: 2

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M chrome/chrome_installer.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/installer/setup/setup_util.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/installer/setup/setup_util.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/installer/util/util_constants.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
grt (UTC plus 2)
6 years, 9 months ago (2014-03-12 14:27:05 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/197403004/diff/1/chrome/installer/setup/setup_util.cc File chrome/installer/setup/setup_util.cc (right): https://codereview.chromium.org/197403004/diff/1/chrome/installer/setup/setup_util.cc#newcode456 chrome/installer/setup/setup_util.cc:456: I think return base::CPU().has_sse2(); works, in fact I ...
6 years, 9 months ago (2014-03-12 17:15:10 UTC) #2
grt (UTC plus 2)
thanks. https://codereview.chromium.org/197403004/diff/1/chrome/installer/setup/setup_util.cc File chrome/installer/setup/setup_util.cc (right): https://codereview.chromium.org/197403004/diff/1/chrome/installer/setup/setup_util.cc#newcode456 chrome/installer/setup/setup_util.cc:456: On 2014/03/12 17:15:11, cpu wrote: > I think ...
6 years, 9 months ago (2014-03-12 18:24:01 UTC) #3
grt (UTC plus 2)
The CQ bit was checked by grt@chromium.org
6 years, 9 months ago (2014-03-12 18:24:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/197403004/20001
6 years, 9 months ago (2014-03-12 18:25:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/197403004/20001
6 years, 9 months ago (2014-03-12 19:31:02 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 21:57:22 UTC) #7
Message was sent while issue was closed.
Change committed as 256668

Powered by Google App Engine
This is Rietveld 408576698