Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3242)

Unified Diff: chrome/installer/setup/setup_main.cc

Issue 197403004: Exit the installer gracefully if the processor doesn't support SSE2. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: oops Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_installer.gypi ('k') | chrome/installer/setup/setup_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/setup_main.cc
diff --git a/chrome/installer/setup/setup_main.cc b/chrome/installer/setup/setup_main.cc
index 69a2e93067e13be8ce73ed33769c15509ef00898..2562be0823834d3ce13bf9d6b7e10409e77473cd 100644
--- a/chrome/installer/setup/setup_main.cc
+++ b/chrome/installer/setup/setup_main.cc
@@ -1673,6 +1673,12 @@ InstallStatus InstallProductsHelper(
int WINAPI wWinMain(HINSTANCE instance, HINSTANCE prev_instance,
wchar_t* command_line, int show_command) {
+ // Check to see if the CPU is supported before doing anything else. There's
+ // very little than can safely be accomplished if the CPU isn't supported
+ // since dependent libraries (e.g., base) may use invalid instructions.
+ if (!installer::IsProcessorSupported())
+ return installer::CPU_NOT_SUPPORTED;
+
// The exit manager is in charge of calling the dtors of singletons.
base::AtExitManager exit_manager;
CommandLine::Init(0, NULL);
« no previous file with comments | « chrome/chrome_installer.gypi ('k') | chrome/installer/setup/setup_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698