Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 19740: Merge r2876 to the 1.0 release branch.... (Closed)

Created:
11 years, 10 months ago by Mark Larson
Modified:
9 years, 7 months ago
Reviewers:
Dean McNamee
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Merge r2876 to the 1.0 release branch. Add -- as a command line switch parsing terminator. This allows you to launch chrome to a given URL safely, without having to validate the URL and worry it might be interpreted as a dangerous command line argument. TBR=deanm BUG=5825 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9014

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -8 lines) Patch
M base/command_line.h View 3 chunks +9 lines, -6 lines 0 comments Download
M base/command_line.cc View 3 chunks +23 lines, -0 lines 0 comments Download
M base/command_line_unittest.cc View 5 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Larson
11 years, 10 months ago (2009-01-31 02:54:31 UTC) #1
Dean McNamee
11 years, 10 months ago (2009-01-31 10:26:45 UTC) #2
LG.  Did you get the installer changes too?

On 2009/01/31 02:54:31, Mark Larson (Google) wrote:
>

Powered by Google App Engine
This is Rietveld 408576698