Clean up CFX_ImageTransformer.

Clean up CFX_ImageTransformer.

Committed: https://pdfium.googlesource.com/pdfium/+/39fbb7e1c2282a46d9bd3adfd030916dcb0155ef

[Lei Zhang, 2016-05-12 17:02:53]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-05-12 18:49:01]

https://codereview.chromium.org/1973913002/diff/40001/core/fpdfapi/fpdf_font/...
File core/fpdfapi/fpdf_font/cpdf_type3char.cpp (right):

https://codereview.chromium.org/1973913002/diff/40001/core/fpdfapi/fpdf_font/...
core/fpdfapi/fpdf_font/cpdf_type3char.cpp:33: const CFX_DIBSource* pSource =
pPageObj->AsImage()->m_pImage->LoadDIBSource();
unique_ptr here?

https://codereview.chromium.org/1973913002/diff/40001/core/fxge/dib/fx_dib_ma...
File core/fxge/dib/fx_dib_main.cpp (right):

https://codereview.chromium.org/1973913002/diff/40001/core/fxge/dib/fx_dib_ma...
core/fxge/dib/fx_dib_main.cpp:1713: return FALSE;
Duplicate return false at 1715?

https://codereview.chromium.org/1973913002/diff/40001/core/fxge/dib/fx_dib_ma...
core/fxge/dib/fx_dib_main.cpp:1725: std::unique_ptr<CFX_DIBitmap> pBitmap =
std::move(m_pBitmap);
can we just do   
  return std::move(m_pBitmap);
?

https://codereview.chromium.org/1973913002/diff/40001/core/fxge/dib/fx_dib_ma...
core/fxge/dib/fx_dib_main.cpp:1739: ?
(uint8_t*)m_pBitmap->m_pAlphaMask->GetScanline(line)
reinterpret_cast<> also line 1736

https://codereview.chromium.org/1973913002/diff/40001/core/fxge/include/fx_dib.h
File core/fxge/include/fx_dib.h (right):

https://codereview.chromium.org/1973913002/diff/40001/core/fxge/include/fx_di...
core/fxge/include/fx_dib.h:630: FX_RECT m_result;
yup.

[Lei Zhang, 2016-05-12 20:14:15]

https://codereview.chromium.org/1973913002/diff/40001/core/fpdfapi/fpdf_font/...
File core/fpdfapi/fpdf_font/cpdf_type3char.cpp (right):

https://codereview.chromium.org/1973913002/diff/40001/core/fpdfapi/fpdf_font/...
core/fpdfapi/fpdf_font/cpdf_type3char.cpp:33: const CFX_DIBSource* pSource =
pPageObj->AsImage()->m_pImage->LoadDIBSource();
On 2016/05/12 18:49:00, Tom Sepez wrote:
> unique_ptr here?

Done.

https://codereview.chromium.org/1973913002/diff/40001/core/fxge/dib/fx_dib_ma...
File core/fxge/dib/fx_dib_main.cpp (right):

https://codereview.chromium.org/1973913002/diff/40001/core/fxge/dib/fx_dib_ma...
core/fxge/dib/fx_dib_main.cpp:1713: return FALSE;
On 2016/05/12 18:49:01, Tom Sepez wrote:
> Duplicate return false at 1715?

Well, this one handles the end of the m_Status == 2 case, and I'd rather it not
fall through.

https://codereview.chromium.org/1973913002/diff/40001/core/fxge/dib/fx_dib_ma...
core/fxge/dib/fx_dib_main.cpp:1725: std::unique_ptr<CFX_DIBitmap> pBitmap =
std::move(m_pBitmap);
On 2016/05/12 18:49:01, Tom Sepez wrote:
> can we just do   
>   return std::move(m_pBitmap);
> ?

Done.

https://codereview.chromium.org/1973913002/diff/40001/core/fxge/dib/fx_dib_ma...
core/fxge/dib/fx_dib_main.cpp:1739: ?
(uint8_t*)m_pBitmap->m_pAlphaMask->GetScanline(line)
On 2016/05/12 18:49:01, Tom Sepez wrote:
> reinterpret_cast<> also line 1736

const_cast :\

https://codereview.chromium.org/1973913002/diff/40001/core/fxge/include/fx_dib.h
File core/fxge/include/fx_dib.h (right):

https://codereview.chromium.org/1973913002/diff/40001/core/fxge/include/fx_di...
core/fxge/include/fx_dib.h:630: FX_RECT m_result;
On 2016/05/12 18:49:01, Tom Sepez wrote:
> yup.

Acknowledged.

[Tom Sepez, 2016-05-12 22:32:49]

lgtm

https://codereview.chromium.org/1973913002/diff/40001/core/fxge/dib/fx_dib_ma...
File core/fxge/dib/fx_dib_main.cpp (right):

https://codereview.chromium.org/1973913002/diff/40001/core/fxge/dib/fx_dib_ma...
core/fxge/dib/fx_dib_main.cpp:1713: return FALSE;
On 2016/05/12 20:14:14, Lei Zhang wrote:
> On 2016/05/12 18:49:01, Tom Sepez wrote:
> > Duplicate return false at 1715?
> 
> Well, this one handles the end of the m_Status == 2 case, and I'd rather it
not
> fall through.

Acknowledged.

[Lei Zhang, 2016-05-12 22:34:38]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-05-12 22:34:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1973913002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1973913002/60001

[commit-bot: I haz the power, 2016-05-12 22:35:03]

Description was changed from

==========
Clean up CFX_ImageTransformer.
==========

to

==========
Clean up CFX_ImageTransformer.

Committed:
https://pdfium.googlesource.com/pdfium/+/39fbb7e1c2282a46d9bd3adfd030916dcb01...
==========

[commit-bot: I haz the power, 2016-05-12 22:35:04]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/39fbb7e1c2282a46d9bd3adfd030916dcb01...