core/fpdfapi/fpdf_font/cpdf_type3font.cpp - Issue 1973913002: Clean up CFX_ImageTransformer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_font/cpdf_type3font.cpp

Issue 1973913002: Clean up CFX_ImageTransformer. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_font/cpdf_type3font.cpp

diff --git a/core/fpdfapi/fpdf_font/cpdf_type3font.cpp b/core/fpdfapi/fpdf_font/cpdf_type3font.cpp

index be280948ae560cb49069f3971b228829855d42a0..6c339ea5a723bfb3dd65c9e6309a3f0c151aba94 100644

--- a/core/fpdfapi/fpdf_font/cpdf_type3font.cpp

+++ b/core/fpdfapi/fpdf_font/cpdf_type3font.cpp

@@ -136,10 +136,8 @@ CPDF_Type3Char* CPDF_Type3Font::LoadChar(uint32_t charcode, int level) {

ASSERT(!pdfium::ContainsKey(m_CacheMap, charcode));

CPDF_Type3Char* pCachedChar = pNewChar.release();

m_CacheMap[charcode] = pCachedChar;

- if (pCachedChar->m_pForm->GetPageObjectList()->empty()) {

- delete pCachedChar->m_pForm;

- pCachedChar->m_pForm = nullptr;

- }

+ if (pCachedChar->m_pForm->GetPageObjectList()->empty())

+ pCachedChar->m_pForm.reset();

return pCachedChar;

}