Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: BUILD.gn

Issue 1973903004: Move the dependency on "log" to v8's public config (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 210cb590d8bec798436f39af6022857c9712aa1d..0205b83aeffcb053b06fdd337199957cc579e1a1 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -126,6 +126,10 @@ config("external_config") {
]
}
include_dirs = [ "include" ]
+ libs = []
+ if (is_android && current_toolchain != host_toolchain) {
+ libs += [ "log" ]
+ }
}
# This config should only be applied to code that needs to be explicitly
@@ -2061,11 +2065,6 @@ if (is_component_build) {
]
public_configs = [ ":external_config" ]
-
- libs = []
- if (is_android && current_toolchain != host_toolchain) {
- libs += [ "log" ]
- }
}
} else {
group("v8") {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698