Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: BUILD.gn

Issue 1973903004: Move the dependency on "log" to v8's public config (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/arm.gni") 6 import("//build/config/arm.gni")
7 import("//build/config/mips.gni") 7 import("//build/config/mips.gni")
8 import("//build/config/sanitizers/sanitizers.gni") 8 import("//build/config/sanitizers/sanitizers.gni")
9 9
10 if (is_android) { 10 if (is_android) {
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 # This config should only be applied to code using V8 and not any V8 code 119 # This config should only be applied to code using V8 and not any V8 code
120 # itself. 120 # itself.
121 config("external_config") { 121 config("external_config") {
122 if (is_component_build) { 122 if (is_component_build) {
123 defines = [ 123 defines = [
124 "V8_SHARED", 124 "V8_SHARED",
125 "USING_V8_SHARED", 125 "USING_V8_SHARED",
126 ] 126 ]
127 } 127 }
128 include_dirs = [ "include" ] 128 include_dirs = [ "include" ]
129 libs = []
130 if (is_android && current_toolchain != host_toolchain) {
131 libs += [ "log" ]
132 }
129 } 133 }
130 134
131 # This config should only be applied to code that needs to be explicitly 135 # This config should only be applied to code that needs to be explicitly
132 # aware of whether we are using startup data or not. 136 # aware of whether we are using startup data or not.
133 config("external_startup_data") { 137 config("external_startup_data") {
134 if (v8_use_external_startup_data) { 138 if (v8_use_external_startup_data) {
135 defines = [ "V8_USE_EXTERNAL_STARTUP_DATA" ] 139 defines = [ "V8_USE_EXTERNAL_STARTUP_DATA" ]
136 } 140 }
137 } 141 }
138 142
(...skipping 1915 matching lines...) Expand 10 before | Expand all | Expand 10 after
2054 2058
2055 configs -= [ "//build/config/compiler:chromium_code" ] 2059 configs -= [ "//build/config/compiler:chromium_code" ]
2056 configs += [ "//build/config/compiler:no_chromium_code" ] 2060 configs += [ "//build/config/compiler:no_chromium_code" ]
2057 configs += [ 2061 configs += [
2058 ":internal_config", 2062 ":internal_config",
2059 ":features", 2063 ":features",
2060 ":toolchain", 2064 ":toolchain",
2061 ] 2065 ]
2062 2066
2063 public_configs = [ ":external_config" ] 2067 public_configs = [ ":external_config" ]
2064
2065 libs = []
2066 if (is_android && current_toolchain != host_toolchain) {
2067 libs += [ "log" ]
2068 }
2069 } 2068 }
2070 } else { 2069 } else {
2071 group("v8") { 2070 group("v8") {
2072 public_deps = [ 2071 public_deps = [
2073 ":v8_base", 2072 ":v8_base",
2074 snapshot_target, 2073 snapshot_target,
2075 ] 2074 ]
2076 public_configs = [ ":external_config" ] 2075 public_configs = [ ":external_config" ]
2077 } 2076 }
2078 } 2077 }
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
2214 ] 2213 ]
2215 2214
2216 deps = [ 2215 deps = [
2217 ":fuzzer_support", 2216 ":fuzzer_support",
2218 ] 2217 ]
2219 2218
2220 configs = [ 2219 configs = [
2221 ":internal_config", 2220 ":internal_config",
2222 ] 2221 ]
2223 } 2222 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698