Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1973903004: Move the dependency on "log" to v8's public config (Closed)

Created:
4 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move the dependency on "log" to v8's public config BUG=chromium:609107 R=machenbach@chromium.org Committed: https://crrev.com/df4b916e00af0949c698c20b545b0428ea0dc244 Cr-Commit-Position: refs/heads/master@{#36244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M BUILD.gn View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
4 years, 7 months ago (2016-05-13 07:12:49 UTC) #1
Michael Achenbach
lgtm
4 years, 7 months ago (2016-05-13 10:17:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973903004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973903004/1
4 years, 7 months ago (2016-05-13 13:58:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 14:01:12 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 14:03:09 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/df4b916e00af0949c698c20b545b0428ea0dc244
Cr-Commit-Position: refs/heads/master@{#36244}

Powered by Google App Engine
This is Rietveld 408576698