Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1973853002:
Disable GMB VideoFrames if GPU compositing is disabled. (Closed)
|
Created:
4 years, 7 months ago by Daniele Castagna Modified:
4 years, 7 months ago Reviewers:
emircan CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@2704 Target Ref:
refs/pending/branch-heads/2704 Project:
chromium Visibility:
Public. |
DescriptionDisable GMB VideoFrames if GPU compositing is disabled.
When GPU compositing is disabled, GpuMemoryBuffer backed VideoFrames
won't be displayed correctly.
This is most likely the cause of crbug.com/604945
BUG=604945
Review-Url: https://codereview.chromium.org/1972783002
Cr-Commit-Position: refs/heads/master@{#393160}
(cherry picked from commit a82ed96acbda1350db7095bfdf944766a38084d2)
NOTRY=true
NOPRESUBMIT=true
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
The CQ bit was checked by dcastagna@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973853002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
dcastagna@chromium.org changed reviewers: + emircan@chromium.org
This is for 51, that has been merge approved already.
lgtm
The CQ bit was checked by emircan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973853002/1
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== Disable GMB VideoFrames if GPU compositing is disabled. When GPU compositing is disabled, GpuMemoryBuffer backed VideoFrames won't be displayed correctly. This is most likely the cause of crbug.com/604945 BUG=604945 Review-Url: https://codereview.chromium.org/1972783002 Cr-Commit-Position: refs/heads/master@{#393160} (cherry picked from commit a82ed96acbda1350db7095bfdf944766a38084d2) ========== to ========== Disable GMB VideoFrames if GPU compositing is disabled. When GPU compositing is disabled, GpuMemoryBuffer backed VideoFrames won't be displayed correctly. This is most likely the cause of crbug.com/604945 BUG=604945 Review-Url: https://codereview.chromium.org/1972783002 Cr-Commit-Position: refs/heads/master@{#393160} (cherry picked from commit a82ed96acbda1350db7095bfdf944766a38084d2) NOTRY=true ==========
Description was changed from ========== Disable GMB VideoFrames if GPU compositing is disabled. When GPU compositing is disabled, GpuMemoryBuffer backed VideoFrames won't be displayed correctly. This is most likely the cause of crbug.com/604945 BUG=604945 Review-Url: https://codereview.chromium.org/1972783002 Cr-Commit-Position: refs/heads/master@{#393160} (cherry picked from commit a82ed96acbda1350db7095bfdf944766a38084d2) NOTRY=true ========== to ========== Disable GMB VideoFrames if GPU compositing is disabled. When GPU compositing is disabled, GpuMemoryBuffer backed VideoFrames won't be displayed correctly. This is most likely the cause of crbug.com/604945 BUG=604945 Review-Url: https://codereview.chromium.org/1972783002 Cr-Commit-Position: refs/heads/master@{#393160} (cherry picked from commit a82ed96acbda1350db7095bfdf944766a38084d2) NOTRY=true NOPRESUBMIT=true ==========
The CQ bit was checked by emircan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973853002/1
Message was sent while issue was closed.
Description was changed from ========== Disable GMB VideoFrames if GPU compositing is disabled. When GPU compositing is disabled, GpuMemoryBuffer backed VideoFrames won't be displayed correctly. This is most likely the cause of crbug.com/604945 BUG=604945 Review-Url: https://codereview.chromium.org/1972783002 Cr-Commit-Position: refs/heads/master@{#393160} (cherry picked from commit a82ed96acbda1350db7095bfdf944766a38084d2) NOTRY=true NOPRESUBMIT=true ========== to ========== Disable GMB VideoFrames if GPU compositing is disabled. When GPU compositing is disabled, GpuMemoryBuffer backed VideoFrames won't be displayed correctly. This is most likely the cause of crbug.com/604945 BUG=604945 Review-Url: https://codereview.chromium.org/1972783002 Cr-Commit-Position: refs/heads/master@{#393160} (cherry picked from commit a82ed96acbda1350db7095bfdf944766a38084d2) NOTRY=true NOPRESUBMIT=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
