Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1972783002:
Disable GMB VideoFrames if GPU compositing is disabled. (Closed)
|
Created:
4 years, 7 months ago by Daniele Castagna Modified:
4 years, 7 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable GMB VideoFrames if GPU compositing is disabled.
When GPU compositing is disabled, GpuMemoryBuffer backed VideoFrames
won't be displayed correctly.
This is most likely the cause of crbug.com/604945
BUG=604945
Committed: https://crrev.com/a82ed96acbda1350db7095bfdf944766a38084d2
Cr-Commit-Position: refs/heads/master@{#393160}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Address Dana's comment. #Messages
Total messages: 19 (9 generated)
Description was changed from ========== Disable GBM VideoFrames if GPU compositing is disabled. When GPP Compositing is disabled, GpuMemoryBuffer backed VideoFrames won't be displayed correctly. This is most likely the cause of crbug.com/604945 BUG=604945 ========== to ========== Disable GBM VideoFrames if GPU compositing is disabled. When GPU compositing is disabled, GpuMemoryBuffer backed VideoFrames won't be displayed correctly. This is most likely the cause of crbug.com/604945 BUG=604945 ==========
dcastagna@chromium.org changed reviewers: + piman@chromium.org
Should it also check if IsFeatureBlacklisted(gpu::GPU_FEATURE_TYPE_GPU_COMPOSITING)? Is there a better way to check if GPU compositing is disabled from RenderThreadImpl?
lgtm
The CQ bit was checked by dcastagna@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972783002/1
danakj@chromium.org changed reviewers: + danakj@chromium.org
https://codereview.chromium.org/1972783002/diff/1/content/renderer/render_thr... File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/1972783002/diff/1/content/renderer/render_thr... content/renderer/render_thread_impl.cc:1427: !cmd_line->HasSwitch(switches::kDisableGpuCompositing); We also don't use gpu compositing when the channel tells us not to. Should we match? (idk why we have both) https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/r...
The CQ bit was unchecked by dcastagna@chromium.org
On 2016/05/12 at 01:00:08, danakj wrote: > https://codereview.chromium.org/1972783002/diff/1/content/renderer/render_thr... > File content/renderer/render_thread_impl.cc (right): > > https://codereview.chromium.org/1972783002/diff/1/content/renderer/render_thr... > content/renderer/render_thread_impl.cc:1427: !cmd_line->HasSwitch(switches::kDisableGpuCompositing); > We also don't use gpu compositing when the channel tells us not to. Should we match? (idk why we have both) > > https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/r... Updated the patch.
The CQ bit was checked by dcastagna@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org Link to the patchset: https://codereview.chromium.org/1972783002/#ps20001 (title: "Address Dana's comment.")
lgtm again
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972783002/20001
LGTM 2
Description was changed from ========== Disable GBM VideoFrames if GPU compositing is disabled. When GPU compositing is disabled, GpuMemoryBuffer backed VideoFrames won't be displayed correctly. This is most likely the cause of crbug.com/604945 BUG=604945 ========== to ========== Disable GMB VideoFrames if GPU compositing is disabled. When GPU compositing is disabled, GpuMemoryBuffer backed VideoFrames won't be displayed correctly. This is most likely the cause of crbug.com/604945 BUG=604945 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Disable GMB VideoFrames if GPU compositing is disabled. When GPU compositing is disabled, GpuMemoryBuffer backed VideoFrames won't be displayed correctly. This is most likely the cause of crbug.com/604945 BUG=604945 ========== to ========== Disable GMB VideoFrames if GPU compositing is disabled. When GPU compositing is disabled, GpuMemoryBuffer backed VideoFrames won't be displayed correctly. This is most likely the cause of crbug.com/604945 BUG=604945 Committed: https://crrev.com/a82ed96acbda1350db7095bfdf944766a38084d2 Cr-Commit-Position: refs/heads/master@{#393160} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a82ed96acbda1350db7095bfdf944766a38084d2 Cr-Commit-Position: refs/heads/master@{#393160} |
