Change dart2js.dart to use compiler_new.dart

Change dart2js.dart to use compiler_new.dart

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/50b85640b393e972cdd02daafb1c454277ed872f

[Johnni Winther, 2016-05-13 12:33:49]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-05-14 00:21:35]

lgtm

https://codereview.chromium.org/1973753004/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/analyze_test_test.dart (right):

https://codereview.chromium.org/1973753004/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/analyze_test_test.dart:84: } else {
does this relates to the other changes in this CL?

The logic here was a bit hard to follow because I wasn't sure why a file would
be a filter :)...

Consider using an extra flag instead (e.g. --filter=...) or make the code more
explicit that this filter is a different kind of argument, for example, by
requiring that it has to be the first non-option argument and that everything
afterwards must be a valid file path. For example:

bool first = true;
for (String arg in arguments) {
  if (arg.startsWith('-')) {
    options.add(arg == '-v' ? Flags.verbose : arg);
  } else {
    if (new File(arg).existsSync()) {
      files.add(arg);
    } else if (first) {
      filter = arg;
    } else {
      ERROR()!!!!
    }
    first = false;
  }
}

[Johnni Winther, 2016-05-17 10:22:39]

https://codereview.chromium.org/1973753004/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/analyze_test_test.dart (right):

https://codereview.chromium.org/1973753004/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/analyze_test_test.dart:84: } else {
On 2016/05/14 00:21:35, Siggi Cherem (dart-lang) wrote:
> does this relates to the other changes in this CL?

Nah. It was used to help create the CL, though.

> The logic here was a bit hard to follow because I wasn't sure why a file would
> be a filter :)...
> 
> Consider using an extra flag instead (e.g. --filter=...) or make the code more
> explicit that this filter is a different kind of argument, for example, by
> requiring that it has to be the first non-option argument and that everything
> afterwards must be a valid file path. For example:
> 
> bool first = true;
> for (String arg in arguments) {
>   if (arg.startsWith('-')) {
>     options.add(arg == '-v' ? Flags.verbose : arg);
>   } else {
>     if (new File(arg).existsSync()) {
>       files.add(arg);
>     } else if (first) {
>       filter = arg;
>     } else {
>       ERROR()!!!!
>     }
>     first = false;
>   }
> }

Done.

[Johnni Winther, 2016-05-17 10:27:28]

Description was changed from

==========
Change dart2js.dart to use compiler_new.dart

BUG=
==========

to

==========
Change dart2js.dart to use compiler_new.dart

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/50b85640b393e972cdd02daafb1c454277ed872f
==========

[Johnni Winther, 2016-05-17 10:27:30]

Committed patchset #3 (id:40001) manually as
50b85640b393e972cdd02daafb1c454277ed872f (presubmit successful).