Change dart2js.dart to use compiler_new.dart

tests/compiler/dart2js/analyze_test_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.analyze_test.test;
 
 import 'dart:io';
 
 import 'package:async_helper/async_helper.dart';
 import 'package:compiler/src/apiimpl.dart' show
@@ skipping 48 matching lines @@
 main(List<String> arguments) {
   List<String> options = <String>[];
   for (String argument in arguments) {
     if (argument == '-v') {
       options.add(Flags.verbose);
     } else if (argument.startsWith('-')) {
       options.add(argument);
     }
   }
   List<Uri> uriList = <Uri>[];
+  String filter;
   for (String arg in arguments) {
     if (!arg.startsWith('-')) {
-      for (String line in new File(arg).readAsLinesSync()) {
-        line = line.trim();
-        if (line.startsWith('Analyzing uri: ')) {
-          int filenameOffset = line.indexOf('tests/compiler/dart2js/');
-          if (filenameOffset != -1) {
-            uriList.add(Uri.base.resolve(
-                nativeToUriPath(line.substring(filenameOffset))));
+      File file = new File(arg);
+      if (file.existsSync()) {
+        for (String line in file.readAsLinesSync()) {
+          line = line.trim();
+          if (line.startsWith('Analyzing uri: ')) {
+            int filenameOffset = line.indexOf('tests/compiler/dart2js/');
+            if (filenameOffset != -1) {
+              uriList.add(Uri.base.resolve(
+                  nativeToUriPath(line.substring(filenameOffset))));
+            }
           }
         }
+      } else {

[Siggi Cherem (dart-lang), 2016/05/14 00:21:35]

does this relates to the other changes in this CL?

The logic here was a bit hard to follow because I wasn't sure why a file would
be a filter :)...

Consider using an extra flag instead (e.g. --filter=...) or make the code more
explicit that this filter is a different kind of argument, for example, by
requiring that it has to be the first non-option argument and that everything
afterwards must be a valid file path. For example:

bool first = true;
for (String arg in arguments) {
  if (arg.startsWith('-')) {
    options.add(arg == '-v' ? Flags.verbose : arg);
  } else {
    if (new File(arg).existsSync()) {
      files.add(arg);
    } else if (first) {
      filter = arg;
    } else {
      ERROR()!!!!
    }
    first = false;
  }
}

[Johnni Winther, 2016/05/17 10:22:39]

Nah. It was used to help create the CL, though.
Done.

+        filter = arg;
       }
     }
   }
 
   asyncTest(() async {
     if (uriList.isEmpty) {
       Directory dir =
           new Directory.fromUri(Uri.base.resolve('tests/compiler/dart2js/'));
       for (FileSystemEntity entity in dir.listSync(recursive: true)) {
         if (entity is File && entity.path.endsWith('.dart')) {
           Uri file = Uri.base.resolve(nativeToUriPath(entity.path));
+          if (filter != null && !'$file'.contains(filter)) {
+            continue;
+          }
           if (!SKIP_LIST.any((skip) => file.path.contains(skip))) {
             uriList.add(file);
           }
         }
       }
     }
     await analyze(
         uriList,
         WHITE_LIST,
         mode: AnalysisMode.URI,
         options: options,
         skipList: MESSAGE_SKIP_LIST);
   });
 }