MD Settings: About page, setup for showing a sub-page.

MD Settings: About page, setup for showing a sub-page.

 - Enhancing about page with necessary setup for displaying (and animating)
   a subpage.
 - Adding dummy subpage, which is also reflected at
   chrome://md-settings/help/details

This is in preparation of displaying detailed build information for
ChromeOS (platform, firmware, V8 version etc).

BUG=546841
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1fb97c70133a0364b58a2f29f4a14a7bc69509a0
Cr-Commit-Position: refs/heads/master@{#393332}

[dpapad, 2016-05-11 23:52:05]

Description was changed from

==========
MD Settings: About page, setup for showing a sub-page.

BUG=546841
==========

to

==========
MD Settings: About page, setup for showing a sub-page.

BUG=546841
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-05-11 23:56:43]

Description was changed from

==========
MD Settings: About page, setup for showing a sub-page.

BUG=546841
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: About page, setup for showing a sub-page.

 - Enhancing about page with necessary setup for displaying (and animating)
   a subpage.
 - Adding dummy subpage, which is also reflected at
   chrome://md-settings/help/details

BUG=546841
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-05-12 00:02:09]

Description was changed from

==========
MD Settings: About page, setup for showing a sub-page.

 - Enhancing about page with necessary setup for displaying (and animating)
   a subpage.
 - Adding dummy subpage, which is also reflected at
   chrome://md-settings/help/details

BUG=546841
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: About page, setup for showing a sub-page.

 - Enhancing about page with necessary setup for displaying (and animating)
   a subpage.
 - Adding dummy subpage, which is also reflected at
   chrome://md-settings/help/details

This is in preparation of displaying detailed build information for ChromeOS
(platform, firmware, V8 version etc).

BUG=546841
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-05-12 00:02:09]

dpapad@chromium.org changed reviewers:
+ michaelpg@chromium.org

[dpapad, 2016-05-12 00:02:35]

Description was changed from

==========
MD Settings: About page, setup for showing a sub-page.

 - Enhancing about page with necessary setup for displaying (and animating)
   a subpage.
 - Adding dummy subpage, which is also reflected at
   chrome://md-settings/help/details

This is in preparation of displaying detailed build information for ChromeOS
(platform, firmware, V8 version etc).

BUG=546841
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: About page, setup for showing a sub-page.

 - Enhancing about page with necessary setup for displaying (and animating)
   a subpage.
 - Adding dummy subpage, which is also reflected at
   chrome://md-settings/help/details

This is in preparation of displaying detailed build information for
ChromeOS (platform, firmware, V8 version etc).

BUG=546841
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-05-12 00:36:48]

Patchset #2 (id:20001) has been deleted

[dpapad, 2016-05-12 00:36:53]

Patchset #2 (id:40001) has been deleted

[dpapad, 2016-05-12 00:37:58]

Screenshot of dummy subpage at http://imgur.com/WgAX1tY.

[michaelpg, 2016-05-12 00:56:11]

lgtm

i *almost* think it may be better to have two separate files if the About page
only has sub-pages on Chrome OS. but it's probably not a big enough deal to
matter

https://codereview.chromium.org/1973733002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/about_page/about_page.html (right):

https://codereview.chromium.org/1973733002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/about_page/about_page.html:5: <link
rel="import" href="chrome://md-settings/settings_page/settings_subpage.html">
ifdef

[dpapad, 2016-05-12 17:45:43]

Regarding having two separate files, one for Chrome, one for ChromeOS, it would
require some code replication, since the ChromeOS part is a superset of the
Chrome part.

https://codereview.chromium.org/1973733002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/about_page/about_page.html (right):

https://codereview.chromium.org/1973733002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/about_page/about_page.html:5: <link
rel="import" href="chrome://md-settings/settings_page/settings_subpage.html">
On 2016/05/12 at 00:56:11, michaelpg wrote:
> ifdef

Done.

[dpapad, 2016-05-12 17:47:27]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-05-12 17:47:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1973733002/#ps2 (title:
"Addressing comment.")

[commit-bot: I haz the power, 2016-05-12 17:47:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1973733002/2
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1973733002/2

[commit-bot: I haz the power, 2016-05-12 18:11:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 18:11:01]

Try jobs failed on following builders:
  closure_compilation on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[Dan Beam, 2016-05-12 18:29:46]

https://codereview.chromium.org/1973733002/diff/2/chrome/browser/resources/se...
File chrome/browser/resources/settings/about_page/about_page.js (right):

https://codereview.chromium.org/1973733002/diff/2/chrome/browser/resources/se...
chrome/browser/resources/settings/about_page/about_page.js:12: behaviors:
[RoutableBehavior],
probably just need to add this as a compiled_resources2.gyp and/or <link
rel=import> dependency

[dpapad, 2016-05-12 18:46:27]

Fixed Closure compilation.

https://codereview.chromium.org/1973733002/diff/2/chrome/browser/resources/se...
File chrome/browser/resources/settings/about_page/about_page.js (right):

https://codereview.chromium.org/1973733002/diff/2/chrome/browser/resources/se...
chrome/browser/resources/settings/about_page/about_page.js:12: behaviors:
[RoutableBehavior],
On 2016/05/12 at 18:29:46, Dan Beam wrote:
> probably just need to add this as a compiled_resources2.gyp and/or <link
rel=import> dependency

Added to compiled_resources2.gyp. The HTML import already exists
(settings_page/main_page_behavior.html).

[dpapad, 2016-05-12 18:48:13]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-05-12 18:48:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1973733002/#ps90001
(title: "Fixing Closure compilation.")

[commit-bot: I haz the power, 2016-05-12 18:48:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1973733002/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1973733002/90001

[commit-bot: I haz the power, 2016-05-12 19:33:52]

Committed patchset #4 (id:90001)

[commit-bot: I haz the power, 2016-05-12 19:35:55]

Description was changed from

==========
MD Settings: About page, setup for showing a sub-page.

 - Enhancing about page with necessary setup for displaying (and animating)
   a subpage.
 - Adding dummy subpage, which is also reflected at
   chrome://md-settings/help/details

This is in preparation of displaying detailed build information for
ChromeOS (platform, firmware, V8 version etc).

BUG=546841
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: About page, setup for showing a sub-page.

 - Enhancing about page with necessary setup for displaying (and animating)
   a subpage.
 - Adding dummy subpage, which is also reflected at
   chrome://md-settings/help/details

This is in preparation of displaying detailed build information for
ChromeOS (platform, firmware, V8 version etc).

BUG=546841
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1fb97c70133a0364b58a2f29f4a14a7bc69509a0
Cr-Commit-Position: refs/heads/master@{#393332}
==========

[commit-bot: I haz the power, 2016-05-12 19:35:57]

Patchset 4 (id:??) landed as
https://crrev.com/1fb97c70133a0364b58a2f29f4a14a7bc69509a0
Cr-Commit-Position: refs/heads/master@{#393332}