 Chromium Code Reviews
 Chromium Code Reviews Issue 1973733002:
  MD Settings: About page, setup for showing a sub-page.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1973733002:
  MD Settings: About page, setup for showing a sub-page.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW | 
|---|---|
| 1 <link rel="import" href="chrome://resources/html/polymer.html"> | 1 <link rel="import" href="chrome://resources/html/polymer.html"> | 
| 2 <link rel="import" href="chrome://md-settings/settings_page/main_page_behavior.h tml"> | |
| 3 <link rel="import" href="chrome://md-settings/settings_page/settings_animated_pa ges.html"> | |
| 2 <link rel="import" href="chrome://md-settings/settings_page/settings_section.htm l"> | 4 <link rel="import" href="chrome://md-settings/settings_page/settings_section.htm l"> | 
| 5 <link rel="import" href="chrome://md-settings/settings_page/settings_subpage.htm l"> | |
| 
michaelpg
2016/05/12 00:56:11
ifdef
 
dpapad
2016/05/12 17:45:43
Done.
 | |
| 3 <link rel="import" href="chrome://md-settings/settings_shared_css.html"> | 6 <link rel="import" href="chrome://md-settings/settings_shared_css.html"> | 
| 7 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html"> | |
| 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> | 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> | 
| 5 | 9 | 
| 6 <dom-module id="settings-about-page"> | 10 <dom-module id="settings-about-page"> | 
| 7 <link rel="import" type="css" href="chrome://md-settings/settings_page.css"> | 11 <link rel="import" type="css" href="chrome://md-settings/settings_page.css"> | 
| 8 <template> | 12 <template> | 
| 9 <style include="settings-shared"> | 13 <style include="settings-shared main-page-styles"> | 
| 10 span { | 14 span { | 
| 11 font-size: 20px; | 15 font-size: 20px; | 
| 12 margin-top: auto; | 16 margin-top: auto; | 
| 13 margin-bottom: auto; | 17 margin-bottom: auto; | 
| 14 } | 18 } | 
| 15 | 19 | 
| 16 img { | 20 img { | 
| 17 -webkit-margin-end: 10px; | 21 -webkit-margin-end: 10px; | 
| 18 } | 22 } | 
| 19 </style> | 23 </style> | 
| 20 <settings-section page-title="$i18n{aboutPageTitle}" | 24 <settings-section page-title="$i18n{aboutPageTitle}" | 
| 21 current-route="[[currentRoute]]"> | 25 current-route="[[currentRoute]]" section="about"> | 
| 22 <div class="settings-box"> | 26 <settings-animated-pages id="pages" current-route="{{currentRoute}}" | 
| 23 <img id="product-logo" | 27 section="about"> | 
| 24 srcset="chrome://theme/current-channel-logo@1x 1x, | 28 <neon-animatable id="main"> | 
| 25 chrome://theme/current-channel-logo@2x 2x" alt=""> | 29 <div class="settings-box"> | 
| 26 <span>$i18n{aboutProductTitle}</span> | 30 <img id="product-logo" | 
| 27 </div> | 31 srcset="chrome://theme/current-channel-logo@1x 1x, | 
| 28 <div class="settings-box two-line"> | 32 chrome://theme/current-channel-logo@2x 2x" alt=""> | 
| 29 <!-- TODO(dpapad): Implement this. --> | 33 <span>$i18n{aboutProductTitle}</span> | 
| 30 <div class="start"> | 34 </div> | 
| 31 <div>Your device is up to date</div> | 35 <div class="settings-box two-line"> | 
| 32 <div class="secondary">Version Foo.bar.baz</div> | 36 <!-- TODO(dpapad): Implement this. --> | 
| 33 </div> | 37 <div class="start"> | 
| 34 <paper-button class="secondary-action">Check for update</paper-button> | 38 <div>Your device is up to date</div> | 
| 35 </div> | 39 <div class="secondary">Version Foo.bar.baz</div> | 
| 36 <div class="settings-box two-line"> | 40 </div> | 
| 37 <!-- TODO(dpapad): Implement this. --> | 41 <paper-button class="secondary-action">Check for update</paper-butto n> | 
| 38 <div class="start"> | 42 </div> | 
| 39 <div>Get help with Chrome</div> | 43 <div class="settings-box two-line"> | 
| 40 <div class="secondary">Open the Help Center</div> | 44 <!-- TODO(dpapad): Implement this. --> | 
| 41 </div> | 45 <div class="start"> | 
| 42 </div> | 46 <div>Get help with Chrome</div> | 
| 43 <div class="settings-box"> | 47 <div class="secondary">Open the Help Center</div> | 
| 44 <!-- TODO(dpapad): Implement this. --> | 48 </div> | 
| 45 Report an issue | 49 </div> | 
| 46 </div> | 50 <div class="settings-box"> | 
| 47 <div class="settings-box"> | 51 <!-- TODO(dpapad): Implement this. --> | 
| 48 <!-- TODO(dpapad): Implement this. --> | 52 Report an issue | 
| 49 Other info here | 53 </div> | 
| 50 </div> | 54 <if expr="chromeos"> | 
| 55 <div class="settings-box" on-tap="onDetailedBuildInfoTap_"> | |
| 56 <!-- TODO(dpapad): Localize string. --> | |
| 57 Detailed build info | |
| 58 </div> | |
| 59 </if> | |
| 60 </neon-animatable> | |
| 61 <if expr="chromeos"> | |
| 62 <template is="dom-if" name="detailed-build-info"> | |
| 63 <settings-subpage page-title="Detailed build information"> | |
| 64 <!-- TODO(dpapad): Implement this. --> | |
| 65 <div>Detailed build info goes here</div> | |
| 66 </settings-subpage> | |
| 67 </template> | |
| 68 </if> | |
| 69 </settings-animated-pages> | |
| 51 </settings-section> | 70 </settings-section> | 
| 52 </template> | 71 </template> | 
| 53 <script src="about_page.js"></script> | 72 <script src="about_page.js"></script> | 
| 54 </dom-module> | 73 </dom-module> | 
| OLD | NEW |