Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1973563002: Revert of Make SkGpuBlurUtils::GaussianBlur more drawContext centric (Closed)

Created:
4 years, 7 months ago by scroggo
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make SkGpuBlurUtils::GaussianBlur more drawContext centric (patchset #2 id:20001 of https://codereview.chromium.org/1962903003/ ) Reason for revert: This looks to be causing errors in Gold. I don't know if I can make a permanent link to something in Gold, but take a look at imagefilterscropexpand for an example. Original issue's description: > Make SkGpuBlurUtils::GaussianBlur more drawContext centric > > This is split out of https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils) > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1962903003 > > Committed: https://skia.googlesource.com/skia/+/e7ef01dcfda0f8ae407ba92cc03cf3f7841ec470 TBR=bsalomon@google.com,robertphillips@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/6a51491b2491a646f2e378ccbae301136b6ec215

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -76 lines) Patch
M src/effects/SkBlurImageFilter.cpp View 1 chunk +9 lines, -10 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 2 chunks +10 lines, -6 lines 0 comments Download
M src/effects/SkGpuBlurUtils.h View 2 chunks +16 lines, -14 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 7 chunks +92 lines, -46 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scroggo
Created Revert of Make SkGpuBlurUtils::GaussianBlur more drawContext centric
4 years, 7 months ago (2016-05-11 17:20:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973563002/1
4 years, 7 months ago (2016-05-11 17:20:56 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 17:21:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6a51491b2491a646f2e378ccbae301136b6ec215

Powered by Google App Engine
This is Rietveld 408576698