Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1973503002: Revert of Add directory option for JUnit coverage files. (Closed)

Created:
4 years, 7 months ago by jbudorick
Modified:
4 years, 7 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add directory option for JUnit coverage files. (patchset #7 id:120001 of https://codereview.chromium.org/1957023002/ ) Reason for revert: Seemingly breaks incremental builds. Original issue's description: > Add directory option for JUnit coverage files. > > Added runtime option --coverage-dir to let the users decide where to store > coverage.ec. > > BUG=608072 > > Committed: https://crrev.com/de08f6f711ebd74fe493584e0694bcce51693318 > Cr-Commit-Position: refs/heads/master@{#392727} TBR=mikecase@chromium.org,hzl@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=608072 Committed: https://crrev.com/0b730799f2f2f2d9d07b75f3fadd2ed387336a02 Cr-Commit-Position: refs/heads/master@{#392908}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -33 lines) Patch
M build/android/gyp/create_java_binary_script.py View 2 chunks +1 line, -11 lines 0 comments Download
M build/android/pylib/junit/test_runner.py View 2 chunks +7 lines, -19 lines 0 comments Download
M build/android/test_runner.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jbudorick
Created Revert of Add directory option for JUnit coverage files.
4 years, 7 months ago (2016-05-11 13:13:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973503002/1
4 years, 7 months ago (2016-05-11 13:13:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 13:14:05 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0b730799f2f2f2d9d07b75f3fadd2ed387336a02 Cr-Commit-Position: refs/heads/master@{#392908}
4 years, 7 months ago (2016-05-11 13:15:10 UTC) #5
mikecase (-- gone --)
4 years, 7 months ago (2016-05-11 17:41:24 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698