Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Side by Side Diff: build/android/pylib/junit/test_runner.py

Issue 1973503002: Revert of Add directory option for JUnit coverage files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/gyp/create_java_binary_script.py ('k') | build/android/test_runner.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import json 5 import json
6 import os 6 import os
7 import tempfile 7 import tempfile
8 8
9 from devil.utils import cmd_helper 9 from devil.utils import cmd_helper
10 from pylib import constants 10 from pylib import constants
11 from pylib.results import json_results 11 from pylib.results import json_results
12 12
13 class JavaTestRunner(object): 13 class JavaTestRunner(object):
14 """Runs java tests on the host.""" 14 """Runs java tests on the host."""
15 15
16 def __init__(self, args): 16 def __init__(self, args):
17 self._package_filter = args.package_filter 17 self._package_filter = args.package_filter
18 self._runner_filter = args.runner_filter 18 self._runner_filter = args.runner_filter
19 self._sdk_version = args.sdk_version 19 self._sdk_version = args.sdk_version
20 self._test_filter = args.test_filter 20 self._test_filter = args.test_filter
21 self._test_suite = args.test_suite 21 self._test_suite = args.test_suite
22 self._coverage_dir = args.coverage_dir
23 22
24 def SetUp(self): 23 def SetUp(self):
25 pass 24 pass
26 25
27 def RunTest(self, _test): 26 def RunTest(self, _test):
28 """Runs junit tests from |self._test_suite|.""" 27 """Runs junit tests from |self._test_suite|."""
29 with tempfile.NamedTemporaryFile() as json_file: 28 with tempfile.NamedTemporaryFile() as json_file:
30 java_script = os.path.join( 29 java_script = os.path.join(
31 constants.GetOutDirectory(), 'bin', 'helper', self._test_suite) 30 constants.GetOutDirectory(), 'bin', 'helper', self._test_suite)
32 command = [java_script] 31 command = [java_script,
33 32 '-test-jars', self._test_suite + '.jar',
34 # Add Jar arguments. 33 '-json-results-file', json_file.name]
35 args = ['-test-jars', self._test_suite + '.jar',
36 '-json-results-file', json_file.name]
37 if self._test_filter: 34 if self._test_filter:
38 args.extend(['-gtest-filter', self._test_filter]) 35 command.extend(['-gtest-filter', self._test_filter])
39 if self._package_filter: 36 if self._package_filter:
40 args.extend(['-package-filter', self._package_filter]) 37 command.extend(['-package-filter', self._package_filter])
41 if self._runner_filter: 38 if self._runner_filter:
42 args.extend(['-runner-filter', self._runner_filter]) 39 command.extend(['-runner-filter', self._runner_filter])
43 if self._sdk_version: 40 if self._sdk_version:
44 args.extend(['-sdk-version', self._sdk_version]) 41 command.extend(['-sdk-version', self._sdk_version])
45 command.extend(['--jar-args', '"%s"' % ' '.join(args)])
46
47 # Add JVM arguments.
48 args = []
49 if self._coverage_dir:
50 args.append('-Demma.coverage.out.file=%s' % self._coverage_dir)
51 if args:
52 command.extend(['--jvm-args', '"%s"' % ' '.join(args)])
53
54 return_code = cmd_helper.RunCmd(command) 42 return_code = cmd_helper.RunCmd(command)
55 results_list = json_results.ParseResultsFromJson( 43 results_list = json_results.ParseResultsFromJson(
56 json.loads(json_file.read())) 44 json.loads(json_file.read()))
57 return (results_list, return_code) 45 return (results_list, return_code)
58 46
59 def TearDown(self): 47 def TearDown(self):
60 pass 48 pass
61 49
OLDNEW
« no previous file with comments | « build/android/gyp/create_java_binary_script.py ('k') | build/android/test_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698