Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1973363002: Reland of move v8_toolset_for_d8 flag (Closed)

Created:
4 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of move v8_toolset_for_d8 flag (patchset #2 id:80001 of https://codereview.chromium.org/1974773002/ ) Reason for revert: Addressed link failure Original issue's description: > Revert of Remove v8_toolset_for_d8 flag (patchset #1 id:1 of https://codereview.chromium.org/1969793002/ ) > > Reason for revert: > blocks roll: https://codereview.chromium.org/1975753002/ > > Original issue's description: > > Remove v8_toolset_for_d8 flag > > > > R=machenbach@chromium.org > > BUG=chromium:609107 > > > > Committed: https://crrev.com/6cb38427984f3c31ff6c8813535cfd6ebf6058c4 > > Cr-Commit-Position: refs/heads/master@{#36198} > > TBR=machenbach@chromium.org,jochen@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:609107 > > Committed: https://crrev.com/b33f9a6f24edef8447adcfb028b7f1d6e291c34e > Cr-Commit-Position: refs/heads/master@{#36209} TBR=machenbach@chromium.org,hablich@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:609107 Committed: https://crrev.com/baf1204df1d6d1823382fdaac7c193ce289f0031 Cr-Commit-Position: refs/heads/master@{#36250}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -57 lines) Patch
M BUILD.gn View 3 chunks +44 lines, -49 lines 0 comments Download
M gypfiles/toolchain.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M src/d8.gyp View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
jochen (gone - plz use gerrit)
Created Reland of move v8_toolset_for_d8 flag
4 years, 7 months ago (2016-05-13 15:27:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973363002/1
4 years, 7 months ago (2016-05-13 15:27:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973363002/1
4 years, 7 months ago (2016-05-13 15:32:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973363002/1
4 years, 7 months ago (2016-05-13 16:01:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 16:11:31 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/baf1204df1d6d1823382fdaac7c193ce289f0031 Cr-Commit-Position: refs/heads/master@{#36250}
4 years, 7 months ago (2016-05-13 16:13:22 UTC) #7
Michael Achenbach
4 years, 7 months ago (2016-05-17 09:10:31 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698