gypfiles/toolchain.gypi - Issue 1973363002: Reland of move v8_toolset_for_d8 flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gypfiles/toolchain.gypi

Issue 1973363002: Reland of move v8_toolset_for_d8 flag (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gypfiles/toolchain.gypi

diff --git a/gypfiles/toolchain.gypi b/gypfiles/toolchain.gypi

index ee6cd20067554e4b8bdb80916765d4acabaa1875..bc3ee5efa30beca7551963df92ef80baa7d658fd 100644

--- a/gypfiles/toolchain.gypi

+++ b/gypfiles/toolchain.gypi

@@ -75,11 +75,6 @@

# Chrome needs this definition unconditionally. For standalone V8 builds,

# it's handled in gypfiles/standalone.gypi.

'want_separate_host_toolset%': 1,

- # Toolset the d8 binary should be compiled for. Possible values are 'host'

- # and 'target'. If you want to run v8 tests, it needs to be set to 'target'.

- # The setting is ignored if want_separate_host_toolset is 0.

- 'v8_toolset_for_d8%': 'target',

# Toolset the shell binary should be compiled for. Possible values are

# 'host' and 'target'.

« no previous file with comments | « BUILD.gn ('k') | src/d8.gyp » ('j') | no next file with comments »