Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1973253002: Remove passing of --jarjar to jni_generator.py (Closed)

Created:
4 years, 7 months ago by kjellander_chromium
Modified:
4 years, 7 months ago
Reviewers:
jbudorick, Torne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove passing of --jarjar to jni_generator.py The flag was removed in https://codereview.chromium.org/1959583003 but the GYP action or GN template were not updated. This only hits GYP since the GN template has a check before adding the flag. R=torne@chromium.org Committed: https://crrev.com/ac9ef746e4c0c207d7b02ddd9db894ae21044636 Cr-Commit-Position: refs/heads/master@{#393564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M build/config/android/rules.gni View 1 chunk +0 lines, -6 lines 0 comments Download
M build/jni_generator.gypi View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
kjellander_chromium
4 years, 7 months ago (2016-05-13 07:42:58 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973253002/1
4 years, 7 months ago (2016-05-13 07:43:22 UTC) #3
kjellander_chromium
+agrieve for build/ OWNERS
4 years, 7 months ago (2016-05-13 08:43:20 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-13 08:54:14 UTC) #8
Torne
LGTM Sorry, I thought I'd already removed this from the build config, and there are ...
4 years, 7 months ago (2016-05-13 10:04:38 UTC) #9
kjellander_chromium
adding jbudorick@chromium.org since agrieve@ is OOO
4 years, 7 months ago (2016-05-13 17:02:17 UTC) #11
jbudorick
lgtm
4 years, 7 months ago (2016-05-13 17:03:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973253002/1
4 years, 7 months ago (2016-05-13 17:16:17 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 17:20:48 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 17:22:14 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac9ef746e4c0c207d7b02ddd9db894ae21044636
Cr-Commit-Position: refs/heads/master@{#393564}

Powered by Google App Engine
This is Rietveld 408576698