Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 1959583003: jni_generator: remove obsolete/unused features. (Closed)

Created:
4 years, 7 months ago by Torne
Modified:
4 years, 7 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

jni_generator: remove obsolete/unused features. Remove several features that Chromium doesn't use from the JNI generator to help simplify its code (in advance of making further changes and refactorings). --jarjar used to be used by WebView but isn't used any more. --pure_native_methods, --jni_init_native_name, and --eager_called_by_natives have never been used in Chromium and were only implemented for other consumers of the script who no longer update from the Chromium version (since past changes to the script introduced more Chromium dependencies). BUG= Committed: https://crrev.com/2005cc358a6ab988aa925f9186c2104a46b174a9 Cr-Commit-Position: refs/heads/master@{#392343}

Patch Set 1 #

Patch Set 2 : Undo whitespace change to reduce diff to golden files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -724 lines) Patch
M base/android/jni_generator/jni_generator.py View 1 26 chunks +16 lines, -200 lines 0 comments Download
M base/android/jni_generator/jni_generator_tests.py View 5 chunks +0 lines, -94 lines 0 comments Download
D base/android/jni_generator/testEagerCalledByNativesOption.golden View 1 chunk +0 lines, -149 lines 0 comments Download
D base/android/jni_generator/testJNIInitNativeNameOption.golden View 1 chunk +0 lines, -75 lines 0 comments Download
D base/android/jni_generator/testJarJarRemapping.golden View 1 chunk +0 lines, -116 lines 0 comments Download
M base/android/jni_generator/testNativeExportsOption.golden View 1 1 chunk +1 line, -10 lines 0 comments Download
M base/android/jni_generator/testNativeExportsOptionalOption.golden View 1 2 chunks +1 line, -10 lines 0 comments Download
D base/android/jni_generator/testPureNativeMethodsOption.golden View 1 chunk +0 lines, -70 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959583003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959583003/20001
4 years, 7 months ago (2016-05-06 11:10:43 UTC) #2
Torne
Checked with g3 consumers of the script and their copy is already forked and unlikely ...
4 years, 7 months ago (2016-05-06 11:11:30 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-06 11:42:24 UTC) #6
rmcilroy
LGTM given we have already diverged from other users of the tool. Thanks.
4 years, 7 months ago (2016-05-09 16:28:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959583003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959583003/20001
4 years, 7 months ago (2016-05-09 16:32:14 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-09 17:08:30 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 17:10:21 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2005cc358a6ab988aa925f9186c2104a46b174a9
Cr-Commit-Position: refs/heads/master@{#392343}

Powered by Google App Engine
This is Rietveld 408576698