Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: chrome/renderer/extensions/dom_activity_logger.cc

Issue 19730002: V8ValueConverter for the activity logger that does not invoke interceptors and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: a nit Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/dom_activity_logger.cc
diff --git a/chrome/renderer/extensions/dom_activity_logger.cc b/chrome/renderer/extensions/dom_activity_logger.cc
index 95d1c11b08f2aad195d2235aa3250776fe409e47..ad5032ce5bd0706489723caec0ef451802f6ad3c 100644
--- a/chrome/renderer/extensions/dom_activity_logger.cc
+++ b/chrome/renderer/extensions/dom_activity_logger.cc
@@ -8,8 +8,8 @@
#include "chrome/common/extensions/dom_action_types.h"
#include "chrome/common/extensions/extension_messages.h"
#include "chrome/renderer/chrome_render_process_observer.h"
+#include "chrome/renderer/extensions/activity_log_value_converter.h"
#include "content/public/renderer/render_thread.h"
-#include "content/public/renderer/v8_value_converter.h"
#include "third_party/WebKit/public/platform/WebString.h"
#include "third_party/WebKit/public/web/WebDOMActivityLogger.h"
#include "v8/include/v8.h"
@@ -29,11 +29,11 @@ void DOMActivityLogger::log(
int argc,
const v8::Handle<v8::Value> argv[],
const WebString& call_type) {
- scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
+ ActivityLogValueConverter converter;
scoped_ptr<ListValue> argv_list_value(new ListValue());
for (int i =0; i < argc; i++) {
argv_list_value->Set(
- i, converter->FromV8Value(argv[i], v8::Context::GetCurrent()));
+ i, converter.FromV8Value(argv[i], v8::Context::GetCurrent()));
}
ExtensionHostMsg_DOMAction_Params params;
params.url = url_;

Powered by Google App Engine
This is Rietveld 408576698