Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1351)

Unified Diff: chrome/renderer/extensions/api_activity_logger.cc

Issue 19730002: V8ValueConverter for the activity logger that does not invoke interceptors and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: a nit Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/api_activity_logger.cc
diff --git a/chrome/renderer/extensions/api_activity_logger.cc b/chrome/renderer/extensions/api_activity_logger.cc
index 28a4367ff15f71d4732f49d8f6997e162e8ca8b3..d14dadc7abe4ed35a89e1e418a25a641c517b368 100644
--- a/chrome/renderer/extensions/api_activity_logger.cc
+++ b/chrome/renderer/extensions/api_activity_logger.cc
@@ -6,11 +6,9 @@
#include "base/bind.h"
#include "chrome/common/extensions/extension_messages.h"
#include "chrome/renderer/chrome_render_process_observer.h"
+#include "chrome/renderer/extensions/activity_log_value_converter.h"
#include "chrome/renderer/extensions/api_activity_logger.h"
#include "content/public/renderer/render_thread.h"
-#include "content/public/renderer/v8_value_converter.h"
-
-using content::V8ValueConverter;
namespace extensions {
@@ -55,11 +53,11 @@ void APIActivityLogger::LogInternal(
// Get the array of api call arguments.
v8::Local<v8::Array> arg_array = v8::Local<v8::Array>::Cast(args[2]);
if (arg_array->Length() > 0) {
- scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
+ ActivityLogValueConverter converter;
scoped_ptr<ListValue> arg_list(new ListValue());
for (size_t i = 0; i < arg_array->Length(); ++i) {
arg_list->Set(i,
- converter->FromV8Value(arg_array->Get(i),
+ converter.FromV8Value(arg_array->Get(i),
v8::Context::GetCurrent()));
}
params.arguments.Swap(arg_list.get());
@@ -82,9 +80,9 @@ void APIActivityLogger::LogBlockedCallWrapper(
DCHECK(args[1]->IsString());
DCHECK(args[2]->IsNumber());
int result;
- scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
- converter->FromV8Value(args[2],
- v8::Context::GetCurrent())->GetAsInteger(&result);
+ ActivityLogValueConverter converter;
+ converter.FromV8Value(args[2],
+ v8::Context::GetCurrent())->GetAsInteger(&result);
LogBlockedCall(*v8::String::AsciiValue(args[0]),
*v8::String::AsciiValue(args[1]),
static_cast<Feature::AvailabilityResult>(result));

Powered by Google App Engine
This is Rietveld 408576698