third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html - Issue 1972943002: Modifies few gc related layout tests to work with ignition.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html

Issue 1972943002: Modifies few gc related layout tests to work with ignition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <div>Test passes if it does not crash</div>	2 <div>Test passes if it does not crash</div>

3 <script src="../../../resources/gc.js"></script>	3 <script src="../../../resources/gc.js"></script>

4 <script>	4 <script>

5 if (window.testRunner) {	5 if (window.testRunner) {

6 testRunner.waitUntilDone();	6 testRunner.waitUntilDone();

7 testRunner.dumpAsText();	7 testRunner.dumpAsText();

	8 }

	9 var observer, div;

	10

	11 function initializeObserver() {

	12 observer = new MutationObserver(

	13 function() {console.log('Should not appear')});

	14 div = document.createElement('div');

	15 observer.observe(div, {attributes: true});

	16 div.id = 'foo';

8 }	17 }

9 var observer = new MutationObserver(function() {console.log('Should not appear') });	18

10 var div = document.createElement('div');	19 // Perform all assignments in a function to avoid references to objects

11 observer.observe(div, {attributes: true});	20 // in dead registers when using ignition (chromium:595672)
	rmcilroy 2016/05/13 11:29:37 /s/Perform all assignments in a function/Do initia /s/Perform all assignments in a function/Do initialization work in an inner function/ /s/in dead registers/remaining live on this function's stack frame/ /s/(chromium:595672)/ - http://crbug.com/595672/ And thoughout. mythria 2016/05/16 11:15:10 Done. Show quoted text On 2016/05/13 11:29:37, rmcilroy wrote: > /s/Perform all assignments in a function/Do initialization work in an inner > function/ > /s/in dead registers/remaining live on this function's stack frame/ > /s/(chromium:595672)/ - http://crbug.com/595672/ > > And thoughout. Done.
12 div.id = 'foo';	21 initializeObserver();

13 div = null;	22 div = null;

14 observer = null;	23 observer = null;

15 gc();	24 gc();

16 setTimeout(function() { testRunner.notifyDone(); }, 0);	25 setTimeout(function() { testRunner.notifyDone(); }, 0);

17 </script>	26 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dom/NodeList/nodelist-reachable.html » ('j') | no next file with comments »