Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1972933002: Fail gracefully if MakeRenderTarget fails (Closed)

Created:
4 years, 7 months ago by scroggo_chromium
Modified:
4 years, 7 months ago
Reviewers:
scroggo, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fail gracefully if MakeRenderTarget fails We recently started passing --preAbandonGpuContext when running DM on valgrind, resulting in this call returning nullptr. We had not been checking for it, so we crash. Already fixed one in crrev.com/1959173002, and now we reach another one. BUG=skia:5282 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1972933002 Committed: https://skia.googlesource.com/skia/+/a1b283345b27fef91908b104a30cb89e6fbdaade

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M gm/image_shader.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
scroggo_chromium
4 years, 7 months ago (2016-05-12 12:57:09 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972933002/1
4 years, 7 months ago (2016-05-12 12:57:23 UTC) #5
robertphillips
lgtm
4 years, 7 months ago (2016-05-12 13:15:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972933002/1
4 years, 7 months ago (2016-05-12 13:18:44 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 13:19:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a1b283345b27fef91908b104a30cb89e6fbdaade

Powered by Google App Engine
This is Rietveld 408576698