gm/image_shader.cpp - Issue 1972933002: Fail gracefully if MakeRenderTarget fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/image_shader.cpp

Issue 1972933002: Fail gracefully if MakeRenderTarget fails (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/image_shader.cpp

diff --git a/gm/image_shader.cpp b/gm/image_shader.cpp

index 214b05d80cf3cf56e3716841311c05f97ecdda70..924199e6e7fcf0b3463d5b2acac134ce5fcb23ed 100644

--- a/gm/image_shader.cpp

+++ b/gm/image_shader.cpp

@@ -38,6 +38,9 @@ static sk_sp<SkImage> make_texture(GrContext* ctx, SkPicture* pic, const SkImage

return nullptr;

}

auto surface(SkSurface::MakeRenderTarget(ctx, SkBudgeted::kNo, info));

+ if (!surface) {

+ return nullptr;

+ }

surface->getCanvas()->clear(0);

surface->getCanvas()->drawPicture(pic);

return surface->makeImageSnapshot();

« no previous file with comments | « no previous file | no next file » | no next file with comments »