X-DevTools-Emulate-Network-Conditions-Client-Id header shouldn't block cache reuse

X-DevTools-Emulate-Network-Conditions-Client-Id header shouldn't block cache reuse

This was regressed in https://chromium.googlesource.com/chromium/src/+/1bef485187d2a5eff4fd471cbb0ec97e61759811,
which caused the header to be present on Resource's
m_resourceRequest, where previously it was added to a copy
of that object.

BUG=603118
TEST=RawResourceTest.CanReuseDevToolsEmulateNetworkConditionsClientIdHeader

Committed: https://crrev.com/91ebc4432e63a720d84f38db343b65a0334d0273
Cr-Commit-Position: refs/heads/master@{#393539}

[Nate Chapin, 2016-05-12 22:42:28]

Description was changed from

==========
X-DevTools-Emulate-Network-Conditions-Client-Id header shouldn't block cache
reuse

BUG=603118
TEST=RawResourceTest.CanReuseDevToolsEmulateNetworkConditionsClientIdHeader
==========

to

==========
X-DevTools-Emulate-Network-Conditions-Client-Id header shouldn't block cache
reuse

This was regressed in
https://chromium.googlesource.com/chromium/src/+/1bef485187d2a5eff4fd471cbb0e...,
which caused the header to be present on Resource's
m_resourceRequest, where previously it was added to a copy
of that object.

BUG=603118
TEST=RawResourceTest.CanReuseDevToolsEmulateNetworkConditionsClientIdHeader
==========

[Nate Chapin, 2016-05-13 15:26:36]

japhet@chromium.org changed reviewers:
+ pfeldman@chromium.org

[Nate Chapin, 2016-05-13 15:26:37]

pfeldman, would you mind reviewing this?

https://codereview.chromium.org/1972923004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/network/HTTPNames.in (right):

https://codereview.chromium.org/1972923004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/network/HTTPNames.in:56:
X-DevTools-Emulate-Network-Conditions-Client-Id
InspectorInstrumentation isn't supposed to be used from core/fetch. Moving the
header's definition here.

[pfeldman, 2016-05-13 16:11:45]

lgtm

[Nate Chapin, 2016-05-13 16:13:21]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2016-05-13 16:13:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972923004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972923004/1

[commit-bot: I haz the power, 2016-05-13 16:17:22]

Description was changed from

==========
X-DevTools-Emulate-Network-Conditions-Client-Id header shouldn't block cache
reuse

This was regressed in
https://chromium.googlesource.com/chromium/src/+/1bef485187d2a5eff4fd471cbb0e...,
which caused the header to be present on Resource's
m_resourceRequest, where previously it was added to a copy
of that object.

BUG=603118
TEST=RawResourceTest.CanReuseDevToolsEmulateNetworkConditionsClientIdHeader
==========

to

==========
X-DevTools-Emulate-Network-Conditions-Client-Id header shouldn't block cache
reuse

This was regressed in
https://chromium.googlesource.com/chromium/src/+/1bef485187d2a5eff4fd471cbb0e...,
which caused the header to be present on Resource's
m_resourceRequest, where previously it was added to a copy
of that object.

BUG=603118
TEST=RawResourceTest.CanReuseDevToolsEmulateNetworkConditionsClientIdHeader
==========

[commit-bot: I haz the power, 2016-05-13 16:17:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-13 16:18:39]

Description was changed from

==========
X-DevTools-Emulate-Network-Conditions-Client-Id header shouldn't block cache
reuse

This was regressed in
https://chromium.googlesource.com/chromium/src/+/1bef485187d2a5eff4fd471cbb0e...,
which caused the header to be present on Resource's
m_resourceRequest, where previously it was added to a copy
of that object.

BUG=603118
TEST=RawResourceTest.CanReuseDevToolsEmulateNetworkConditionsClientIdHeader
==========

to

==========
X-DevTools-Emulate-Network-Conditions-Client-Id header shouldn't block cache
reuse

This was regressed in
https://chromium.googlesource.com/chromium/src/+/1bef485187d2a5eff4fd471cbb0e...,
which caused the header to be present on Resource's
m_resourceRequest, where previously it was added to a copy
of that object.

BUG=603118
TEST=RawResourceTest.CanReuseDevToolsEmulateNetworkConditionsClientIdHeader

Committed: https://crrev.com/91ebc4432e63a720d84f38db343b65a0334d0273
Cr-Commit-Position: refs/heads/master@{#393539}
==========

[commit-bot: I haz the power, 2016-05-13 16:18:40]

Patchset 1 (id:??) landed as
https://crrev.com/91ebc4432e63a720d84f38db343b65a0334d0273
Cr-Commit-Position: refs/heads/master@{#393539}