third_party/WebKit/Source/core/fetch/RawResourceTest.cpp - Issue 1972923004: X-DevTools-Emulate-Network-Conditions-Client-Id header shouldn't block cache reuse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/RawResourceTest.cpp

Issue 1972923004: X-DevTools-Emulate-Network-Conditions-Client-Id header shouldn't block cache reuse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/RawResource.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h » ('j') | third_party/WebKit/Source/platform/network/HTTPNames.in » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/RawResourceTest.cpp

diff --git a/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp b/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp

index 9b3085d1c1ce6f94dde84057387abf321182e4fa..a405dd7b92ed771920ef44e3f4b8bc10bbff1a07 100644

--- a/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp

+++ b/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp

@@ -291,4 +291,12 @@ TEST(RawResourceTest, RemoveClientDuringCallback)

EXPECT_FALSE(raw->hasClientsOrObservers());

}

+TEST(RawResourceTest, CanReuseDevToolsEmulateNetworkConditionsClientIdHeader)

+ ResourceRequest request("data:text/html,");

+ request.setHTTPHeaderField(HTTPNames::X_DevTools_Emulate_Network_Conditions_Client_Id, "Foo");

+ Resource* raw = RawResource::create(request, Resource::Raw);

+ EXPECT_TRUE(raw->canReuse(ResourceRequest("data:text/html,")));

} // namespace blink