MacViews GN: Get chrome compiling with mac_views_browser = true

MacViews GN: Get chrome compiling with mac_views_browser = true

Three things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the libbrowser.a library and
symbols in libbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/download
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa
* proximity_auth_error_bubble.cc had stubs only used by Cocoa.

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms - fix that).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324
Committed: https://crrev.com/64351f1c48aebf9167b6b1a0cfcec6a1779fbffa
Cr-Commit-Position: refs/heads/master@{#394068}

[tapted, 2016-05-12 07:20:14]

Description was changed from

==========
MacViews GN: chrome compiles with mac_views_browser = true


BUG=
==========

to

==========
MacViews GN: chrome compiles with mac_views_browser = true


BUG=611324
==========

[tapted, 2016-05-13 04:48:56]

Description was changed from

==========
MacViews GN: chrome compiles with mac_views_browser = true


BUG=611324
==========

to

==========
MacViews GN: chrome compiles with mac_views_browser = true

Two things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the lbibrowser.a library and
stuff in ilbbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/dowload
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324
==========

[tapted, 2016-05-13 04:49:22]

Description was changed from

==========
MacViews GN: chrome compiles with mac_views_browser = true

Two things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the lbibrowser.a library and
stuff in ilbbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/dowload
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324
==========

to

==========
MacViews GN: chrome compiles with mac_views_browser = true

Two things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the lbibrowser.a library and
stuff in ilbbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/download
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324
==========

[tapted, 2016-05-13 04:49:40]

Description was changed from

==========
MacViews GN: chrome compiles with mac_views_browser = true

Two things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the lbibrowser.a library and
stuff in ilbbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/download
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324
==========

to

==========
MacViews GN: chrome compiles with mac_views_browser = true

Two things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the libbrowser.a library and
stuff in ilbbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/download
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324
==========

[tapted, 2016-05-13 04:50:52]

Description was changed from

==========
MacViews GN: chrome compiles with mac_views_browser = true

Two things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the libbrowser.a library and
stuff in ilbbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/download
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324
==========

to

==========
MacViews GN: Get chrome compiling with mac_views_browser = true

Two things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the libbrowser.a library and
stuff in ilbbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/download
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324
==========

[tapted, 2016-05-13 04:51:13]

Description was changed from

==========
MacViews GN: Get chrome compiling with mac_views_browser = true

Two things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the libbrowser.a library and
stuff in ilbbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/download
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324
==========

to

==========
MacViews GN: Get chrome compiling with mac_views_browser = true

Two things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the libbrowser.a library and
symbols in ilbbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/download
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324
==========

[tapted, 2016-05-13 04:51:45]

Description was changed from

==========
MacViews GN: Get chrome compiling with mac_views_browser = true

Two things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the libbrowser.a library and
symbols in ilbbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/download
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324
==========

to

==========
MacViews GN: Get chrome compiling with mac_views_browser = true

Two things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the libbrowser.a library and
symbols in ilbbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/download
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms - fix that).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324
==========

[tapted, 2016-05-13 04:55:25]

Description was changed from

==========
MacViews GN: Get chrome compiling with mac_views_browser = true

Two things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the libbrowser.a library and
symbols in ilbbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/download
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms - fix that).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324
==========

to

==========
MacViews GN: Get chrome compiling with mac_views_browser = true

There things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the libbrowser.a library and
symbols in ilbbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/download
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa
* proximity_auth_error_bubble.cc had stubs only used by Cocoa.

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms - fix that).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324
==========

[tapted, 2016-05-13 13:04:59]

Description was changed from

==========
MacViews GN: Get chrome compiling with mac_views_browser = true

There things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the libbrowser.a library and
symbols in ilbbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/download
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa
* proximity_auth_error_bubble.cc had stubs only used by Cocoa.

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms - fix that).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324
==========

to

==========
MacViews GN: Get chrome compiling with mac_views_browser = true

Three things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the libbrowser.a library and
symbols in ilbbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/download
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa
* proximity_auth_error_bubble.cc had stubs only used by Cocoa.

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms - fix that).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324
==========

[tapted, 2016-05-13 13:05:00]

tapted@chromium.org changed reviewers:
+ rsesek@chromium.org

[tapted, 2016-05-13 13:06:11]

Hi Robert, please take a look.

[Robert Sesek, 2016-05-13 18:38:42]

Description was changed from

==========
MacViews GN: Get chrome compiling with mac_views_browser = true

Three things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the libbrowser.a library and
symbols in ilbbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/download
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa
* proximity_auth_error_bubble.cc had stubs only used by Cocoa.

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms - fix that).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324
==========

to

==========
MacViews GN: Get chrome compiling with mac_views_browser = true

Three things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the libbrowser.a library and
symbols in libbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/download
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa
* proximity_auth_error_bubble.cc had stubs only used by Cocoa.

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms - fix that).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324
==========

[Robert Sesek, 2016-05-13 18:52:40]

LGTM, thanks for handling this!

[tapted, 2016-05-16 06:48:04]

tapted@chromium.org changed reviewers:
+ asanka@chromium.org, msw@chromium.org

[tapted, 2016-05-16 06:51:29]

+asanka,msw for OWNERS

asanka: chrome/browser/downloads (and ui/cocoa/downloads)
msw: chrome/browser/ui

Thanks!

[asanka, 2016-05-16 17:05:45]

/downloads/ lgtm

[msw, 2016-05-16 19:17:03]

lgtm with optional nits and a q

https://codereview.chromium.org/1972843002/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/create_application_shortcut_cocoa.mm (right):

https://codereview.chromium.org/1972843002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/create_application_shortcut_cocoa.mm:17: using
web_app::ShortcutInfo;
optional nit: inline namespace in one use.

https://codereview.chromium.org/1972843002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/create_application_shortcut_cocoa.mm:18: using
web_app::ShortcutLocations;
nit: remove if not used

https://codereview.chromium.org/1972843002/diff/40001/chrome/chrome_browser_u...
File chrome/chrome_browser_ui.gypi (right):

https://codereview.chromium.org/1972843002/diff/40001/chrome/chrome_browser_u...
chrome/chrome_browser_ui.gypi:1316:
'browser/ui/proximity_auth/proximity_auth_error_bubble.h',
Doesn't
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
still include this file on non-Mac platforms?

[tapted, 2016-05-17 03:38:37]

https://codereview.chromium.org/1972843002/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/create_application_shortcut_cocoa.mm (right):

https://codereview.chromium.org/1972843002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/create_application_shortcut_cocoa.mm:17: using
web_app::ShortcutInfo;
On 2016/05/16 19:17:03, msw wrote:
> optional nit: inline namespace in one use.

Done.

https://codereview.chromium.org/1972843002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/create_application_shortcut_cocoa.mm:18: using
web_app::ShortcutLocations;
On 2016/05/16 19:17:03, msw wrote:
> nit: remove if not used

Done - there was just one use. I think I left these in to try and minimize the
diff, but this new file was too small in the end anyway :)

https://codereview.chromium.org/1972843002/diff/40001/chrome/chrome_browser_u...
File chrome/chrome_browser_ui.gypi (right):

https://codereview.chromium.org/1972843002/diff/40001/chrome/chrome_browser_u...
chrome/chrome_browser_ui.gypi:1316:
'browser/ui/proximity_auth/proximity_auth_error_bubble.h',
On 2016/05/16 19:17:03, msw wrote:
> Doesn't
> chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
> still include this file on non-Mac platforms?

ooh - good catch. Moved it back and renamed proximity_auth_error_bubble.cc to
proximity_auth_error_bubble_stub.cc so it's clear

[tapted, 2016-05-17 03:39:08]

The CQ bit was checked by tapted@chromium.org

[tapted, 2016-05-17 03:39:09]

The patchset sent to the CQ was uploaded after l-g-t-m from asanka@chromium.org,
msw@chromium.org, rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/1972843002/#ps60001
(title: "msw comments")

[commit-bot: I haz the power, 2016-05-17 03:39:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972843002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972843002/60001

[commit-bot: I haz the power, 2016-05-17 03:41:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 03:41:11]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[tapted, 2016-05-17 04:51:05]

Patchset #5 (id:80001) has been deleted

[tapted, 2016-05-17 04:51:28]

The CQ bit was checked by tapted@chromium.org

[tapted, 2016-05-17 04:51:29]

The patchset sent to the CQ was uploaded after l-g-t-m from asanka@chromium.org,
msw@chromium.org, rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/1972843002/#ps100001
(title: "rebase (patch failure due to r393625)")

[commit-bot: I haz the power, 2016-05-17 04:51:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972843002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972843002/100001

[commit-bot: I haz the power, 2016-05-17 06:11:03]

Description was changed from

==========
MacViews GN: Get chrome compiling with mac_views_browser = true

Three things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the libbrowser.a library and
symbols in libbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/download
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa
* proximity_auth_error_bubble.cc had stubs only used by Cocoa.

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms - fix that).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324
==========

to

==========
MacViews GN: Get chrome compiling with mac_views_browser = true

Three things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the libbrowser.a library and
symbols in libbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/download
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa
* proximity_auth_error_bubble.cc had stubs only used by Cocoa.

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms - fix that).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324
==========

[commit-bot: I haz the power, 2016-05-17 06:11:04]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-05-17 06:12:45]

Description was changed from

==========
MacViews GN: Get chrome compiling with mac_views_browser = true

Three things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the libbrowser.a library and
symbols in libbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/download
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa
* proximity_auth_error_bubble.cc had stubs only used by Cocoa.

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms - fix that).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324
==========

to

==========
MacViews GN: Get chrome compiling with mac_views_browser = true

Three things only used by Mac+Cocoa (not mac_views_browser), but ignored
when linking with gyp since they were in the libbrowser.a library and
symbols in libbrowser_ui.a took precedence:
* Moves DownloadDangerPromptImpl from c/b/download to
c/b/ui/cocoa/download
* Moves chrome::ShowCreateChromeAppShortcutsDialog from
c/b/web_applications to c/b/ui/cocoa
* proximity_auth_error_bubble.cc had stubs only used by Cocoa.

Remove immersive_mode_controller_factory_mac.cc - Cocoa doesn't use it,
and mac_views_browser has an implementation in c/b/ui/views

gyp doesn't automatically strip _aura files -- move some aura-only stuff
into chrome_browser_ui_aura_sources. (x11_panel_resizer is Linux only
but was actually being compiled on all aura platforms - fix that).

chrome_browser_ui_views_*non_mac*_sources had some _mac stuff used by
mac_views_browser=1 builds, move these to
chrome_browser_ui_views_mac_experimental_sources to avoid confusion.

BUG=611324

Committed: https://crrev.com/64351f1c48aebf9167b6b1a0cfcec6a1779fbffa
Cr-Commit-Position: refs/heads/master@{#394068}
==========

[commit-bot: I haz the power, 2016-05-17 06:12:46]

Patchset 5 (id:??) landed as
https://crrev.com/64351f1c48aebf9167b6b1a0cfcec6a1779fbffa
Cr-Commit-Position: refs/heads/master@{#394068}