chrome/browser/ui/BUILD.gn - Issue 1972843002: MacViews GN: Get chrome compiling with mac_views_browser = true

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 1972843002: MacViews GN: Get chrome compiling with mac_views_browser = true (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase (patch failure due to r393625) Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_danger_prompt.cc ('k') | chrome/browser/ui/cocoa/create_application_shortcut_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/BUILD.gn

diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn

index 01851a610c8d040c1732b2d1ca443efc74effabd..d4d7089ebc1d47d7518b31ccf820a05381b7df1f 100644

--- a/chrome/browser/ui/BUILD.gn

+++ b/chrome/browser/ui/BUILD.gn

@@ -431,6 +431,12 @@ source_set("ui") {

gypi_values.chrome_browser_ui_views_extensions_non_mac_sources,

".",

"//chrome")

+ sources -= [

+ "views/extensions/extension_popup_aura.cc",

+ "views/extensions/extension_popup_aura.h",

+ ]

deps += [ "//extensions/components/native_app_window" ]

} else {

sources += rebase_path(gypi_values.chrome_browser_ui_cocoa_sources,

« no previous file with comments | « chrome/browser/download/download_danger_prompt.cc ('k') | chrome/browser/ui/cocoa/create_application_shortcut_cocoa.mm » ('j') | no next file with comments »