Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Issue 197283042: Remove use of a V8 isolate outside of bindings code in ImageBitmapFactories.cpp. (Closed)

Created:
6 years, 9 months ago by rmacnak
Modified:
6 years, 9 months ago
CC:
blink-reviews, siva
Visibility:
Public.

Description

Remove use of a V8 isolate outside of bindings code in ImageBitmapFactories.cpp. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170089

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M Source/modules/imagebitmap/ImageBitmapFactories.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rmacnak
6 years, 9 months ago (2014-03-26 00:49:05 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 9 months ago (2014-03-26 08:27:38 UTC) #2
Justin Novosad
On 2014/03/26 08:27:38, jochen wrote: > lgtm lgtm
6 years, 9 months ago (2014-03-26 14:21:58 UTC) #3
rmacnak
The CQ bit was checked by rmacnak@google.com
6 years, 9 months ago (2014-03-26 18:03:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmacnak@google.com/197283042/30001
6 years, 9 months ago (2014-03-26 18:04:18 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 18:11:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
6 years, 9 months ago (2014-03-26 18:11:17 UTC) #7
rmacnak
The CQ bit was checked by rmacnak@google.com
6 years, 9 months ago (2014-03-26 19:39:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmacnak@google.com/197283042/30001
6 years, 9 months ago (2014-03-26 19:39:22 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 19:50:14 UTC) #10
Message was sent while issue was closed.
Change committed as 170089

Powered by Google App Engine
This is Rietveld 408576698