Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2078)

Unified Diff: Source/modules/imagebitmap/ImageBitmapFactories.cpp

Issue 197283042: Remove use of a V8 isolate outside of bindings code in ImageBitmapFactories.cpp. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/imagebitmap/ImageBitmapFactories.cpp
diff --git a/Source/modules/imagebitmap/ImageBitmapFactories.cpp b/Source/modules/imagebitmap/ImageBitmapFactories.cpp
index fb6723d7312834a5af4ec218135d874e23ec111d..02dc3fec208b579d692c3f7c9ce21c98063de36b 100644
--- a/Source/modules/imagebitmap/ImageBitmapFactories.cpp
+++ b/Source/modules/imagebitmap/ImageBitmapFactories.cpp
@@ -70,8 +70,7 @@ static ScriptPromise fulfillImageBitmap(ExecutionContext* context, PassRefPtrWil
if (imageBitmap) {
resolver->resolve(imageBitmap);
} else {
- v8::Isolate* isolate = ScriptState::current()->isolate();
- resolver->reject(ScriptValue(v8::Null(isolate), isolate));
+ resolver->reject(ScriptValue::createNull());
}
return promise;
}
@@ -316,9 +315,8 @@ void ImageBitmapFactories::ImageBitmapLoader::loadBlobAsync(ExecutionContext* co
void ImageBitmapFactories::ImageBitmapLoader::rejectPromise()
{
- v8::Isolate* isolate = m_scriptState->isolate();
ScriptScope scope(m_scriptState);
- m_resolver->reject(ScriptValue(v8::Null(isolate), isolate));
+ m_resolver->reject(ScriptValue::createNull());
m_factory->didFinishLoading(this);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698