Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 1972663002: Eagerly remove disposed DOMTimers as observers upon completion. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eagerly remove disposed DOMTimers as observers upon completion. Once the coordinator lets go of a timer, no need to keep it around as an observer of the ExecutionContext. The previous, reverted, attempt (r392309) detached the DOMTimer too soon, causing DOMTimer nesting levels to grow without being reset. R=haraken BUG= Committed: https://crrev.com/6ce5b24bfbde8a3fd8943a3169872022f1084d3f Cr-Commit-Position: refs/heads/master@{#395012}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M third_party/WebKit/Source/core/frame/DOMTimer.cpp View 2 chunks +11 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimerCoordinator.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look. let's try this one again.
4 years, 7 months ago (2016-05-19 21:33:59 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-19 23:41:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972663002/20001
4 years, 7 months ago (2016-05-20 05:22:34 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 06:10:05 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 06:11:12 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6ce5b24bfbde8a3fd8943a3169872022f1084d3f
Cr-Commit-Position: refs/heads/master@{#395012}

Powered by Google App Engine
This is Rietveld 408576698