third_party/WebKit/Source/core/frame/DOMTimerCoordinator.h - Issue 1972663002: Eagerly remove disposed DOMTimers as observers upon completion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMTimerCoordinator.h

Issue 1972663002: Eagerly remove disposed DOMTimers as observers upon completion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMTimer.cpp ('k') | third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/DOMTimerCoordinator.h

diff --git a/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.h b/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.h

index a2d17b328867246571a95867c55d1a5ce61436e5..e3270fa29d3623e3ae3edd9bafbbfd95efc1169a 100644

--- a/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.h

+++ b/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.h

@@ -32,7 +32,7 @@ public:

// Removes and disposes the timer with the specified ID, if any. This may

// destroy the timer.

- void removeTimeoutByID(int id);

+ DOMTimer* removeTimeoutByID(int id);

// Timers created during the execution of other timers, and

// repeating timers, are throttled. Timer nesting level tracks the

« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMTimer.cpp ('k') | third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp » ('j') | no next file with comments »