Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 197263002: Implement PersistentValueMap, a map that stores UniquePersistent values. Part 2. (Closed)

Created:
6 years, 9 months ago by vogelheim
Modified:
6 years, 9 months ago
Reviewers:
dcarney
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Implement PersistentValueMap, a map that stores UniquePersistent values. This is preparatory work to get rid of UnsafePersistent in blink. The previous version had to be reverted due to timeouts in win32/Debug: https://codereview.chromium.org/197173002/ The timeouts happened because the STL version on that platform contains sanity checking code which opens a 'debug window' in the GUI, patiently waiting for the user to click ok/cancel/somethirdoption. It turns out, the cause for that debug window was totally valid and the test had a use-after-free issue. The 1st patch set is the code as before. The 2nd patch set contains the fix. Related blink changes are here: https://codereview.chromium.org/180363004/ This patch is largely based on https://codereview.chromium.org/175503003/, with some methods added to support the blink change mentioned above. BUG= R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19873

Patch Set 1 #

Patch Set 2 : Fix use-after-free in test-api.cc. Now works on win32 Debug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -11 lines) Patch
M include/v8.h View 12 chunks +196 lines, -5 lines 0 comments Download
M src/api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/global-handles.h View 1 chunk +1 line, -1 line 0 comments Download
M src/global-handles.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +110 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vogelheim
PTAL. 2nd try for PersistentValueMap, w/ fix for user-after-free discovered by Win32/debug bot.
6 years, 9 months ago (2014-03-12 16:29:40 UTC) #1
dcarney
lgtm, landing
6 years, 9 months ago (2014-03-13 07:07:52 UTC) #2
dcarney
6 years, 9 months ago (2014-03-13 07:11:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19873 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698