src/api.cc - Issue 197263002: Implement PersistentValueMap, a map that stores UniquePersistent values. Part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 197263002: Implement PersistentValueMap, a map that stores UniquePersistent values. Part 2. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix use-after-free in test-api.cc. Now works on win32 Debug. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index a6ff52ca2fce9f7625b5830777d14516917bdb6c..43069676838e68123f400b2e78ac7d4c38dadac3 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -560,8 +560,8 @@ void V8::MakeWeak(i::Object** object,

}

-void V8::ClearWeak(i::Object** obj) {

- i::GlobalHandles::ClearWeakness(obj);

+void* V8::ClearWeak(i::Object** obj) {

+ return i::GlobalHandles::ClearWeakness(obj);

}

« no previous file with comments | « include/v8.h ('k') | src/global-handles.h » ('j') | no next file with comments »