Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 197243005: Move SkNoSaveLayerCanvas.h to include/utils (Closed)

Created:
6 years, 9 months ago by robertphillips
Modified:
6 years, 9 months ago
Reviewers:
f(malita), reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Move SkNoSaveLayerCanvas.h to include/utils Need to move SkNoSaveLayerCanvas.h somewhere public before Chromium can make use of it (e.g., Make PixelRefUtils::GatherDiscardablePixelRefs use Skia's version of the NoSaveLayerCanvas - https://codereview.chromium.org/199043004/)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Delete and re-add SkNoSaveLayerCanvas.h to work around code review deficiency #

Patch Set 3 : Added SK_API so Chromium can actually use it #

Patch Set 4 : Fix svn patch oddity (I hope) #

Patch Set 5 : remove debugging cruft #

Patch Set 6 : reattach from different machine #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -48 lines) Patch
M gyp/utils.gyp View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
A include/utils/SkNoSaveLayerCanvas.h View 1 2 3 4 5 1 chunk +47 lines, -0 lines 0 comments Download
D src/utils/SkNoSaveLayerCanvas.h View 1 2 3 4 5 1 chunk +0 lines, -47 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
robertphillips
6 years, 9 months ago (2014-03-13 17:57:42 UTC) #1
f(malita)
https://codereview.chromium.org/197243005/diff/1/gyp/utils.gyp File gyp/utils.gyp (right): https://codereview.chromium.org/197243005/diff/1/gyp/utils.gyp#newcode49 gyp/utils.gyp:49: '../include/utils/SkNoSaveLayerCanvas.h', Forgot to add it to the patch?
6 years, 9 months ago (2014-03-13 17:59:25 UTC) #2
robertphillips
https://codereview.chromium.org/197243005/diff/1/gyp/utils.gyp File gyp/utils.gyp (right): https://codereview.chromium.org/197243005/diff/1/gyp/utils.gyp#newcode49 gyp/utils.gyp:49: '../include/utils/SkNoSaveLayerCanvas.h', It is there but not showing up in ...
6 years, 9 months ago (2014-03-13 18:02:07 UTC) #3
f(malita)
On 2014/03/13 18:02:07, robertphillips wrote: > https://codereview.chromium.org/197243005/diff/1/gyp/utils.gyp > File gyp/utils.gyp (right): > > https://codereview.chromium.org/197243005/diff/1/gyp/utils.gyp#newcode49 > ...
6 years, 9 months ago (2014-03-13 18:05:19 UTC) #4
robertphillips
I have explicitly deleted and re-added SkNoSaveLayerCanvas.h to work around the code review issue.
6 years, 9 months ago (2014-03-13 19:08:17 UTC) #5
f(malita)
Chromium usability lgtm :) (but Mike needs to bless the pub api).
6 years, 9 months ago (2014-03-13 19:13:28 UTC) #6
reed1
Oiy, we're promoting an API where the client must give us a device! :( lgtm
6 years, 9 months ago (2014-03-13 19:28:04 UTC) #7
robertphillips
6 years, 9 months ago (2014-03-16 21:59:55 UTC) #8
Message was sent while issue was closed. 
committed as r13823

Powered by Google App Engine
This is Rietveld 408576698