Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 197243002: Make SyncStartupTracker::Observer destructor virtual (Closed)

Created:
6 years, 9 months ago by wdzierzanowski
Modified:
6 years, 9 months ago
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make SyncStartupTracker::Observer destructor virtual Instances of SyncStartupTracker::Observer subclasses are likely to be deleted through a SyncStartupTracker::Observer pointer. While we are here, also put the include of sync_startup_tracker.h first in sync_startup_tracker.cc for reasons stated in the style guide. R=atwilson@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257502

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/sync/sync_startup_tracker.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/sync_startup_tracker.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/sync_startup_tracker_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
wdzierzanowski
6 years, 9 months ago (2014-03-12 12:35:02 UTC) #1
wdzierzanowski
Hi Andrew, Could you take a look please?
6 years, 9 months ago (2014-03-17 09:21:59 UTC) #2
Andrew T Wilson (Slow)
lgtm
6 years, 9 months ago (2014-03-17 09:36:55 UTC) #3
wdzierzanowski
The CQ bit was checked by wdzierzanowski@opera.com
6 years, 9 months ago (2014-03-17 09:43:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wdzierzanowski@opera.com/197243002/1
6 years, 9 months ago (2014-03-17 09:43:23 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 09:44:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-17 09:44:46 UTC) #7
wdzierzanowski
On 2014/03/17 09:44:46, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 9 months ago (2014-03-17 11:40:58 UTC) #8
wdzierzanowski
The CQ bit was checked by wdzierzanowski@opera.com
6 years, 9 months ago (2014-03-17 11:41:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wdzierzanowski@opera.com/197243002/1
6 years, 9 months ago (2014-03-17 11:41:14 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 12:58:48 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-17 12:58:49 UTC) #12
wdzierzanowski
The CQ bit was checked by wdzierzanowski@opera.com
6 years, 9 months ago (2014-03-17 14:11:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wdzierzanowski@opera.com/197243002/1
6 years, 9 months ago (2014-03-17 14:11:35 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 20:59:37 UTC) #15
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-17 20:59:37 UTC) #16
wdzierzanowski
The CQ bit was checked by wdzierzanowski@opera.com
6 years, 9 months ago (2014-03-17 21:44:36 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wdzierzanowski@opera.com/197243002/1
6 years, 9 months ago (2014-03-17 21:45:32 UTC) #18
commit-bot: I haz the power
6 years, 9 months ago (2014-03-17 21:53:03 UTC) #19
Message was sent while issue was closed.
Change committed as 257502

Powered by Google App Engine
This is Rietveld 408576698