chrome/browser/sync/sync_startup_tracker.h - Issue 197243002: Make SyncStartupTracker::Observer destructor virtual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/sync_startup_tracker.h

Issue 197243002: Make SyncStartupTracker::Observer destructor virtual (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/sync_startup_tracker.h

diff --git a/chrome/browser/sync/sync_startup_tracker.h b/chrome/browser/sync/sync_startup_tracker.h

index 419cabaa69e0173bc8ee4e890aeec0619ecafb6f..26dcfeb2696934e14ed9d11a2beb87f31905a00a 100644

--- a/chrome/browser/sync/sync_startup_tracker.h

+++ b/chrome/browser/sync/sync_startup_tracker.h

@@ -22,6 +22,8 @@ class SyncStartupTracker : public ProfileSyncServiceObserver {

// Observer interface used to notify observers when sync has started up.

class Observer {

public:

+ virtual ~Observer() {}

virtual void SyncStartupCompleted() = 0;

virtual void SyncStartupFailed() = 0;

};

« no previous file with comments | « no previous file | chrome/browser/sync/sync_startup_tracker.cc » ('j') | no next file with comments »