mus: Add views_mus_interactive_ui_tests target

mus: Add views_mus_interactive_ui_tests target

* Run widget_interactive_uitests.cc in the new target.
* Added a shared "test_support" target in ui/views/mus.
* Pull ViewsMusTestSuite into its own file so I can share it.
* Also make ViewsTestBase::IsMus static so I can call it before the
  PlatformTestHelper is initialized.
* Disable a bunch of tests that fail on mus (I filed bugs for them).

BUG=602036
TEST=views_interactive_ui_tests on mus, interactive_ui_tests elsewhere

Committed: https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888
Cr-Commit-Position: refs/heads/master@{#394026}

[James Cook, 2016-05-13 16:49:52]

Description was changed from

==========
mus: Run widget interactive uitests under views_mus_unittests

BUG=
==========

to

==========
mus: Run widget interactive uitests under views_mus_unittests

* Also make ViewsTestBase::IsMus static so I can call it before the
  PlatformTestHelper is initialized.
* Disable a bunch of tests that fail on mus (I filed bugs for them).

BUG=602036
TEST=views_mus_unittests on mus, interactive_ui_tests elsewhere
==========

[James Cook, 2016-05-13 17:22:59]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2016-05-13 17:22:59]

sky, please take a look.

[sky, 2016-05-13 19:27:52]

https://codereview.chromium.org/1972363002/diff/10004/ui/views/mus/BUILD.gn
File ui/views/mus/BUILD.gn (right):

https://codereview.chromium.org/1972363002/diff/10004/ui/views/mus/BUILD.gn#n...
ui/views/mus/BUILD.gn:142: "../widget/widget_interactive_uitest.cc",
This needs to be in its own test harness. The reason for that is that these
tests have side effects. For example, they set system level capture. If you run
the tests here the tests will run in parallel, which can lead to flake.

[James Cook, 2016-05-13 23:44:27]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 23:44:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972363002/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972363002/90001

[James Cook, 2016-05-13 23:46:22]

sky, please take another look.

[James Cook, 2016-05-13 23:47:41]

Description was changed from

==========
mus: Run widget interactive uitests under views_mus_unittests

* Also make ViewsTestBase::IsMus static so I can call it before the
  PlatformTestHelper is initialized.
* Disable a bunch of tests that fail on mus (I filed bugs for them).

BUG=602036
TEST=views_mus_unittests on mus, interactive_ui_tests elsewhere
==========

to

==========
mus: Add views_mus_interactive_ui_tests target

* Run widget_interactive_uitests.cc in the new target.
* Added a shared "test_support" target in ui/views/mus.
* Also make ViewsTestBase::IsMus static so I can call it before the
  PlatformTestHelper is initialized.
* Disable a bunch of tests that fail on mus (I filed bugs for them).

BUG=602036
TEST=views_interactive_ui_tests on mus, interactive_ui_tests elsewhere
==========

[commit-bot: I haz the power, 2016-05-14 01:02:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-14 01:02:34]

Dry run: This issue passed the CQ dry run.

[sky, 2016-05-16 15:34:51]

LGTM

[James Cook, 2016-05-16 15:39:46]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-05-16 15:40:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972363002/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972363002/90001

[commit-bot: I haz the power, 2016-05-16 15:47:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-16 15:47:52]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[James Cook, 2016-05-16 15:54:28]

jamescook@chromium.org changed reviewers:
+ dpranke@chromium.org

[James Cook, 2016-05-16 15:54:28]

dpranke, can I get OWNERS for //BUILD.gn? This adds a new test target for the
mus/mustash project.

[Dirk Pranke, 2016-05-16 17:35:06]

lgtm w/ change noted below.

https://codereview.chromium.org/1972363002/diff/90001/ui/views/mus/BUILD.gn
File ui/views/mus/BUILD.gn (right):

https://codereview.chromium.org/1972363002/diff/90001/ui/views/mus/BUILD.gn#n...
ui/views/mus/BUILD.gn:158: data = [
This should be `data_deps = [ "//ui/resources:ui_test_pak_data" ]`.

I'm not sure where this TODO comes from but I'm guessing there are other places
that need to be updated as well.

[James Cook, 2016-05-16 20:09:46]

https://codereview.chromium.org/1972363002/diff/90001/ui/views/mus/BUILD.gn
File ui/views/mus/BUILD.gn (right):

https://codereview.chromium.org/1972363002/diff/90001/ui/views/mus/BUILD.gn#n...
ui/views/mus/BUILD.gn:158: data = [
On 2016/05/16 17:35:06, Dirk Pranke wrote:
> This should be `data_deps = [ "//ui/resources:ui_test_pak_data" ]`.
> 
> I'm not sure where this TODO comes from but I'm guessing there are other
places
> that need to be updated as well.

Done here and in ui/views/BUILD.gn, which seems to be the source of this
particular TODO.

[James Cook, 2016-05-16 20:09:53]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-05-16 20:09:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1972363002/#ps110001
(title: "ui_test_pak_data")

[commit-bot: I haz the power, 2016-05-16 20:10:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972363002/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972363002/110001

[commit-bot: I haz the power, 2016-05-16 20:12:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-16 20:12:58]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[James Cook, 2016-05-16 20:36:38]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-05-16 20:36:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1972363002/#ps130001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-16 20:37:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972363002/130001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972363002/130001

[commit-bot: I haz the power, 2016-05-16 21:47:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-16 21:47:04]

Failed to apply patch for ui/views/mus/platform_test_helper_mus.cc:
While running git apply --index -3 -p1;
  error: ui/views/mus/platform_test_helper_mus.cc: does not exist in index

Patch:       ui/views/mus/platform_test_helper_mus.cc
Index: ui/views/mus/platform_test_helper_mus.cc
diff --git a/ui/views/mus/platform_test_helper_mus.cc
b/ui/views/mus/platform_test_helper_mus.cc
index
8022cd908adc67d3a21dc29f64806ac48aae6e65..406a7e0ac17167f8ac1ff3417d4ca7db4caa255c
100644
--- a/ui/views/mus/platform_test_helper_mus.cc
+++ b/ui/views/mus/platform_test_helper_mus.cc
@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 #include "base/command_line.h"
+#include "base/files/file_path.h"
 #include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "services/shell/background/background_shell.h"
@@ -20,8 +21,6 @@ using shell::BackgroundShell;
 namespace views {
 namespace {
 
-const char kTestName[] = "exe:views_mus_unittests";
-
 class DefaultShellClient : public shell::ShellClient {
  public:
   DefaultShellClient() {}
@@ -39,7 +38,7 @@ class PlatformTestHelperMus : public PlatformTestHelper {
     shell_client_.reset(new DefaultShellClient);
     shell_connection_.reset(new shell::ShellConnection(
         shell_client_.get(),
-        background_shell_->CreateShellClientRequest(kTestName)));
+        background_shell_->CreateShellClientRequest(GetTestName())));
 
     // TODO(rockot): Remove this RunLoop. http://crbug.com/594852.
     base::RunLoop wait_loop;
@@ -59,9 +58,16 @@ class PlatformTestHelperMus : public PlatformTestHelper {
     shell_connection_.reset();
   }
 
-  bool IsMus() const override { return true; }
-
  private:
+  // Returns the name of the test executable, e.g. "exe:views_mus_unittests".
+  std::string GetTestName() {
+    base::FilePath executable = base::CommandLine::ForCurrentProcess()
+                                    ->GetProgram()
+                                    .BaseName()
+                                    .RemoveExtension();
+    return std::string("exe:") + executable.MaybeAsASCII();
+  }
+
   std::unique_ptr<BackgroundShell> background_shell_;
   std::unique_ptr<shell::ShellConnection> shell_connection_;
   std::unique_ptr<DefaultShellClient> shell_client_;
@@ -76,4 +82,9 @@ std::unique_ptr<PlatformTestHelper>
PlatformTestHelper::Create() {
   return base::WrapUnique(new PlatformTestHelperMus);
 }
 
+// static
+bool PlatformTestHelper::IsMus() {
+  return true;
+}
+
 }  // namespace views

[commit-bot: I haz the power, 2016-05-16 21:47:07]

The CQ bit was unchecked by commit-bot@chromium.org

[James Cook, 2016-05-16 23:31:10]

Description was changed from

==========
mus: Add views_mus_interactive_ui_tests target

* Run widget_interactive_uitests.cc in the new target.
* Added a shared "test_support" target in ui/views/mus.
* Also make ViewsTestBase::IsMus static so I can call it before the
  PlatformTestHelper is initialized.
* Disable a bunch of tests that fail on mus (I filed bugs for them).

BUG=602036
TEST=views_interactive_ui_tests on mus, interactive_ui_tests elsewhere
==========

to

==========
mus: Add views_mus_interactive_ui_tests target

* Run widget_interactive_uitests.cc in the new target.
* Added a shared "test_support" target in ui/views/mus.
* Pull ViewsMusTestSuite into its own file so I can share it.
* Also make ViewsTestBase::IsMus static so I can call it before the
  PlatformTestHelper is initialized.
* Disable a bunch of tests that fail on mus (I filed bugs for them).

BUG=602036
TEST=views_interactive_ui_tests on mus, interactive_ui_tests elsewhere
==========

[James Cook, 2016-05-16 23:37:18]

sky, please take another look. The major changes vs. the last CL are pulling
ViewsMusTestSuite into its own file (with no significant functional changes) and
adding PlatformTestHelper::SetIsMus().

[sadrul, 2016-05-17 00:12:04]

sadrul@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2016-05-17 00:12:05]

fwiw lgtm

[James Cook, 2016-05-17 01:57:23]

On 2016/05/17 00:12:05, sadrul wrote:
> fwiw lgtm

Given that the biggest change in this patchset was rebasing on top of Sadrul's
change, and since I've got a couple patches waiting on this one, I'll take
Sadrul's LGTM as sufficient. Thanks!

[James Cook, 2016-05-17 01:57:39]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-05-17 01:57:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1972363002/#ps150001
(title: "rebase onto Sadrul's patch, pull out ViewsMusTestSuite")

[commit-bot: I haz the power, 2016-05-17 01:58:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972363002/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972363002/150001

[commit-bot: I haz the power, 2016-05-17 02:35:16]

Committed patchset #9 (id:150001)

[commit-bot: I haz the power, 2016-05-17 02:36:28]

Description was changed from

==========
mus: Add views_mus_interactive_ui_tests target

* Run widget_interactive_uitests.cc in the new target.
* Added a shared "test_support" target in ui/views/mus.
* Pull ViewsMusTestSuite into its own file so I can share it.
* Also make ViewsTestBase::IsMus static so I can call it before the
  PlatformTestHelper is initialized.
* Disable a bunch of tests that fail on mus (I filed bugs for them).

BUG=602036
TEST=views_interactive_ui_tests on mus, interactive_ui_tests elsewhere
==========

to

==========
mus: Add views_mus_interactive_ui_tests target

* Run widget_interactive_uitests.cc in the new target.
* Added a shared "test_support" target in ui/views/mus.
* Pull ViewsMusTestSuite into its own file so I can share it.
* Also make ViewsTestBase::IsMus static so I can call it before the
  PlatformTestHelper is initialized.
* Disable a bunch of tests that fail on mus (I filed bugs for them).

BUG=602036
TEST=views_interactive_ui_tests on mus, interactive_ui_tests elsewhere

Committed: https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888
Cr-Commit-Position: refs/heads/master@{#394026}
==========

[commit-bot: I haz the power, 2016-05-17 02:36:29]

Patchset 9 (id:??) landed as
https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888
Cr-Commit-Position: refs/heads/master@{#394026}

[James Cook, 2016-05-17 03:03:19]

A revert of this CL (patchset #9 id:150001) has been created in
https://codereview.chromium.org/1980283002/ by jamescook@chromium.org.

The reason for reverting is: Broke Chromium Win on Win x64 Builder (dbg)

[3415/4254] CXX
obj/ui/views/mus/views_mus_interactive_ui_tests/widget_interactive_uitest.obj
FAILED:
obj/ui/views/mus/views_mus_interactive_ui_tests/widget_interactive_uitest.obj 
ninja -t msvc -e environment.x64 -- C:\b\build\slave\cache\cipd\goma/gomacc.exe
"C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64/cl.exe"
/nologo /showIncludes /FC
@obj/ui/views/mus/views_mus_interactive_ui_tests/widget_interactive_uitest.obj.rsp
/c ../../ui/views/widget/widget_interactive_uitest.cc
/Foobj/ui/views/mus/views_mus_interactive_ui_tests/widget_interactive_uitest.obj
/Fd"obj/ui/views/mus/views_mus_interactive_ui_tests_cc.pdb"
c:\b\build\slave\win_x64_builder__dbg_\build\src\ui\views\widget\widget_interactive_uitest.cc(658):
error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win_x64_builder__dbg_\build\src\ui\views\widget\widget_interactive_uitest.cc(658):
warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of
data
.