Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 1978293003: Rename ViewTestSuite to ViewsTestSuite and put it in the proper file (Closed)

Created:
4 years, 7 months ago by James Cook
Modified:
4 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@widgetinteractive
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ViewTestSuite to ViewsTestSuite and put it in the proper file No functional changes. BUG=none TEST=compiles Committed: https://crrev.com/103690c903504b1675259348139be8b4422790eb Cr-Commit-Position: refs/heads/master@{#394260}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -148 lines) Patch
M ui/views/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/mus/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/mus/views_mus_test_suite.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/mus/views_mus_test_suite.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D ui/views/run_all_unittests.h View 1 chunk +0 lines, -47 lines 0 comments Download
D ui/views/run_all_unittests.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M ui/views/run_all_unittests_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/views.gyp View 3 chunks +5 lines, -5 lines 0 comments Download
A + ui/views/views_test_suite.h View 3 chunks +7 lines, -9 lines 0 comments Download
A + ui/views/views_test_suite.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
James Cook
sadrul, please take a look
4 years, 7 months ago (2016-05-16 23:58:35 UTC) #2
sadrul
lgtm
4 years, 7 months ago (2016-05-17 00:10:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978293003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978293003/40001
4 years, 7 months ago (2016-05-17 20:54:24 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-17 23:08:23 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 23:09:35 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/103690c903504b1675259348139be8b4422790eb
Cr-Commit-Position: refs/heads/master@{#394260}

Powered by Google App Engine
This is Rietveld 408576698