Simple program for visualizing gamuts

Simple program for visualizing gamuts

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1972343002

Committed: https://skia.googlesource.com/skia/+/aabe15e206bf7625fecccd9feaebcb06f55f13c5

[msarett, 2016-05-12 23:01:49]

Description was changed from

==========
Simple program for visualizing gamuts

BUG=skia:
==========

to

==========
Simple program for visualizing gamuts

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-05-12 23:02:45]

msarett@google.com changed reviewers:
+ jcgregorio@google.com, reed@google.com

[jcgregorio, 2016-05-13 13:36:36]

https://codereview.chromium.org/1972343002/diff/1/tools/visualize_color_gamut...
File tools/visualize_color_gamut.cpp (right):

https://codereview.chromium.org/1972343002/diff/1/tools/visualize_color_gamut...
tools/visualize_color_gamut.cpp:55: "Output: Outputs visualization of the color
gamut to image_gamut.png\n");
Comment doesn't match actual code, currently writes to "out.png".

https://codereview.chromium.org/1972343002/diff/1/tools/visualize_color_gamut...
tools/visualize_color_gamut.cpp:120: SkFILEWStream stream("out.png");
Can the output filename be made into a flag?

[msarett, 2016-05-13 14:02:05]

https://codereview.chromium.org/1972343002/diff/1/tools/visualize_color_gamut...
File tools/visualize_color_gamut.cpp (right):

https://codereview.chromium.org/1972343002/diff/1/tools/visualize_color_gamut...
tools/visualize_color_gamut.cpp:55: "Output: Outputs visualization of the color
gamut to image_gamut.png\n");
On 2016/05/13 13:36:36, jcgregorio wrote:
> Comment doesn't match actual code, currently writes to "out.png".

Thanks!  Fixed this to use output filename passed by a flag.

https://codereview.chromium.org/1972343002/diff/1/tools/visualize_color_gamut...
tools/visualize_color_gamut.cpp:120: SkFILEWStream stream("out.png");
On 2016/05/13 13:36:36, jcgregorio wrote:
> Can the output filename be made into a flag?

Yes! Done.

[jcgregorio, 2016-05-13 14:08:09]

lgtm

[msarett, 2016-05-13 14:10:17]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-05-13 14:10:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972343002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972343002/20001

[commit-bot: I haz the power, 2016-05-13 14:33:02]

Description was changed from

==========
Simple program for visualizing gamuts

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Simple program for visualizing gamuts

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/aabe15e206bf7625fecccd9feaebcb06f55f13c5
==========

[commit-bot: I haz the power, 2016-05-13 14:33:02]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/aabe15e206bf7625fecccd9feaebcb06f55f13c5

[reed1, 2016-05-17 18:01:49]

Does this guy have a SkIa Server front-end we can try out?