Issue 197223002: Fix broken transition for text-decoration-color.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 197223002: Fix broken transition for text-decoration-color. (Closed)

Created:
6 years, 9 months ago by andersr

Modified:
6 years, 9 months ago

Reviewers:
dstockwell

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Fix broken transition for text-decoration-color. CSSPropertyEquality::propertiesEqual was not implemented for text-decoration-color. Note: The test has a high tolerance, because we really only need to test that the current value is somewhere between the start value and end value. BUG=351675 TEST=test-decoration-color-transition.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169215

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -2 lines)			Patch
A	LayoutTests/transitions/text-decoration-color-transition.html	View	1 chunk	+25 lines, -0 lines	0 comments	Download
A	LayoutTests/transitions/text-decoration-color-transition-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/animation/css/CSSPropertyEquality.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

andersr

The (former) FIXME says it's broken (presumably beyond the scope of that switch-case), but the ...

6 years, 9 months ago (2014-03-12 12:41:57 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/197223002/1

6 years, 9 months ago (2014-03-14 06:22:26 UTC) #3

Message was sent while issue was closed.

Change committed as 169215

Expand Messages | Collapse Messages