Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: Source/core/animation/css/CSSPropertyEquality.cpp

Issue 197223002: Fix broken transition for text-decoration-color. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/transitions/text-decoration-color-transition-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/animation/css/CSSPropertyEquality.h" 6 #include "core/animation/css/CSSPropertyEquality.h"
7 7
8 #include "core/animation/css/CSSAnimations.h" 8 #include "core/animation/css/CSSAnimations.h"
9 #include "core/rendering/style/RenderStyle.h" 9 #include "core/rendering/style/RenderStyle.h"
10 #include "core/rendering/style/ShadowList.h" 10 #include "core/rendering/style/ShadowList.h"
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 return ptrsOrValuesEqual<PassRefPtr<SVGLengthList> >(a.strokeDashArray() , b.strokeDashArray()); 218 return ptrsOrValuesEqual<PassRefPtr<SVGLengthList> >(a.strokeDashArray() , b.strokeDashArray());
219 case CSSPropertyStrokeDashoffset: 219 case CSSPropertyStrokeDashoffset:
220 return ptrsOrValuesEqual<PassRefPtr<SVGLength> >(a.strokeDashOffset(), b .strokeDashOffset()); 220 return ptrsOrValuesEqual<PassRefPtr<SVGLength> >(a.strokeDashOffset(), b .strokeDashOffset());
221 case CSSPropertyStrokeMiterlimit: 221 case CSSPropertyStrokeMiterlimit:
222 return a.strokeMiterLimit() == b.strokeMiterLimit(); 222 return a.strokeMiterLimit() == b.strokeMiterLimit();
223 case CSSPropertyStrokeOpacity: 223 case CSSPropertyStrokeOpacity:
224 return a.strokeOpacity() == b.strokeOpacity(); 224 return a.strokeOpacity() == b.strokeOpacity();
225 case CSSPropertyStrokeWidth: 225 case CSSPropertyStrokeWidth:
226 return ptrsOrValuesEqual<PassRefPtr<SVGLength> >(a.strokeWidth(), b.stro keWidth()); 226 return ptrsOrValuesEqual<PassRefPtr<SVGLength> >(a.strokeWidth(), b.stro keWidth());
227 case CSSPropertyTextDecorationColor: 227 case CSSPropertyTextDecorationColor:
228 // FIXME: transitions of text-decoration-color are broken 228 return a.textDecorationColor().resolve(a.color()) == b.textDecorationCol or().resolve(b.color())
229 return true; 229 && a.visitedLinkTextDecorationColor().resolve(a.color()) == b.visite dLinkTextDecorationColor().resolve(b.color());
230 case CSSPropertyTextIndent: 230 case CSSPropertyTextIndent:
231 return a.textIndent() == b.textIndent(); 231 return a.textIndent() == b.textIndent();
232 case CSSPropertyTextShadow: 232 case CSSPropertyTextShadow:
233 return ptrsOrValuesEqual<ShadowList*>(a.textShadow(), b.textShadow()); 233 return ptrsOrValuesEqual<ShadowList*>(a.textShadow(), b.textShadow());
234 case CSSPropertyTop: 234 case CSSPropertyTop:
235 return a.top() == b.top(); 235 return a.top() == b.top();
236 case CSSPropertyVisibility: 236 case CSSPropertyVisibility:
237 return a.visibility() == b.visibility(); 237 return a.visibility() == b.visibility();
238 case CSSPropertyWebkitBackgroundSize: 238 case CSSPropertyWebkitBackgroundSize:
239 return fillLayersEqual<CSSPropertyWebkitBackgroundSize>(a.backgroundLaye rs(), b.backgroundLayers()); 239 return fillLayersEqual<CSSPropertyWebkitBackgroundSize>(a.backgroundLaye rs(), b.backgroundLayers());
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 return a.zIndex() == b.zIndex(); 301 return a.zIndex() == b.zIndex();
302 case CSSPropertyZoom: 302 case CSSPropertyZoom:
303 return a.zoom() == b.zoom(); 303 return a.zoom() == b.zoom();
304 default: 304 default:
305 ASSERT_NOT_REACHED(); 305 ASSERT_NOT_REACHED();
306 return true; 306 return true;
307 } 307 }
308 } 308 }
309 309
310 } 310 }
OLDNEW
« no previous file with comments | « LayoutTests/transitions/text-decoration-color-transition-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698