Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Issue 1972213003: [DevTools] More UX fixes in Device Mode. (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] More UX fixes in Device Mode. - Add a couple of options to Command Menu; - Fixed a bug with bad scaling in captured screenshot; - Fixed wrong position of outline on small screens; - Added screen border to partial screenshots. BUG=none Committed: https://crrev.com/646a9e6f11d1bf61b5d387f0b0d797f857c9a3eb Cr-Commit-Position: refs/heads/master@{#393441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/module.json View 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 7 months ago (2016-05-12 21:40:52 UTC) #2
pfeldman
lgtm
4 years, 7 months ago (2016-05-13 02:13:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972213003/1
4 years, 7 months ago (2016-05-13 02:16:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 03:22:03 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 03:23:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/646a9e6f11d1bf61b5d387f0b0d797f857c9a3eb
Cr-Commit-Position: refs/heads/master@{#393441}

Powered by Google App Engine
This is Rietveld 408576698