Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js

Issue 1972213003: [DevTools] More UX fixes in Device Mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js
index be1dca8dd9e8acef5678db8de0b605e0a8493064..a23780a975aebeaf4630397ff41afc48d86f9227 100644
--- a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js
@@ -45,7 +45,7 @@ WebInspector.DeviceModeModel = function(updateCallback)
this._deviceScaleFactorSetting = WebInspector.settings.createSetting("emulation.deviceScaleFactor", 0);
this._deviceScaleFactorSetting.addChangeListener(this._deviceScaleFactorSettingChanged, this);
- this._deviceOutlineSetting = WebInspector.settings.createSetting("emulation.deviceOutline", false);
+ this._deviceOutlineSetting = WebInspector.settings.moduleSetting("emulation.showDeviceOutline");
this._deviceOutlineSetting.addChangeListener(this._deviceOutlineSettingChanged, this);
/** @type {!WebInspector.DeviceModeModel.Type} */
@@ -544,7 +544,7 @@ WebInspector.DeviceModeModel.prototype = {
screenSize.width * scale,
screenSize.height * scale);
this._outlineRect = new WebInspector.Rect(
- Math.max(0, this._screenRect.left - outline.left * scale),
+ this._screenRect.left - outline.left * scale,
0,
(outline.left + screenSize.width + outline.right) * scale,
(outline.top + screenSize.height + outline.bottom) * scale);
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698