Issue 197213009: Remove unneeded check in requestPaintingResource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 197213009: Remove unneeded check in requestPaintingResource (Closed)

Created:
6 years, 9 months ago by rwlbuis

Modified:
6 years, 9 months ago

Reviewers:
Stephen Chennney, pdr., fs

CC:
blink-reviews, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, Stephen Chennney, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove unneeded check in requestPaintingResource The check is not needed because hasFill/hasStroke calls above check the same thing. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169262

Patch Set 1 : Invert logic :) #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	Source/core/rendering/svg/RenderSVGResource.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

rwlbuis

Tiny optimization. Works locally but can't prove it until the trybots run....

6 years, 9 months ago (2014-03-14 15:37:02 UTC) #1

On 2014/03/14 15:37:02, rwlbuis wrote: > Tiny optimization. Works locally but can't prove it until ...

6 years, 9 months ago (2014-03-14 16:21:08 UTC) #2

pdr.

On 2014/03/14 16:21:08, fs wrote: > On 2014/03/14 15:37:02, rwlbuis wrote: > > Tiny optimization. ...

6 years, 9 months ago (2014-03-14 16:41:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/197213009/20001

6 years, 9 months ago (2014-03-14 16:41:29 UTC) #5

Message was sent while issue was closed.

Change committed as 169262

Expand Messages | Collapse Messages